From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Date: Mon, 29 Dec 2014 20:31:20 +0100
Subject: [U-Boot] [PATCH 15/17] sunxi: Ippo_q8h defconfigs: Enable the
 LCD panel found on these tablets.
In-Reply-To: <CAGb2v67MkvOCj=yC5zxnb_AFodN4m6EiUUbLS4C_X69Gh3TbMA@mail.gmail.com>
References: <1419447989-21959-1-git-send-email-hdegoede@redhat.com>
	<1419447989-21959-16-git-send-email-hdegoede@redhat.com>
	<CAGb2v64prnWthEU+aw3dk_pN4S=3h=DJM9yh2UxruX9=B2mEQg@mail.gmail.com>
	<549BEE2B.5070803@redhat.com>
	<CAGb2v65jEZf51mwEyKJQz=mnQSyvtNs3G74n2rgS8igJTia=9g@mail.gmail.com>
	<1419861426.13595.92.camel@hellion.org.uk>
	<CAGb2v67MkvOCj=yC5zxnb_AFodN4m6EiUUbLS4C_X69Gh3TbMA@mail.gmail.com>
Message-ID: <54A1AC08.3010908@redhat.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 29-12-14 16:56, Chen-Yu Tsai wrote:
> On Mon, Dec 29, 2014 at 9:57 PM, Ian Campbell <ijc@hellion.org.uk> wrote:
>> On Fri, 2014-12-26 at 14:44 +0800, Chen-Yu Tsai wrote:
>>>> So if I'm not mistaken for the Ippo_q8h_v5 the timings should be:
>>>>
>>>> CONFIG_VIDEO_LCD_MODE="x:800,y:480,depth:18,pclk_khz:33000,le:87,ri:168,up:31,lo:13,hs:1,vs:1,sync:0,vmode:0"
>>>
>>>
>>> The new values look better.
>>
>> Thanks. I've not seen a v2 of this patch, but assuming a patch with
>> these new values were to be posted I would say:
>>      Acked-by: Ian Campbell <ijc@hellion.org.uk>
>>
>> I think we should add your Tested-by too.
>
> Tested-by: Chen-Yu Tsai <wens@csie.org>

Thanks, I've added both the Acked-by  and the Tested-by to the commit in
my personal tree, which has the new values.

Regards,

Hans