public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mx6slevk: Remove get_board_rev()
@ 2014-12-29 20:05 Fabio Estevam
  2014-12-30 13:37 ` Stefano Babic
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2014-12-29 20:05 UTC (permalink / raw)
  To: u-boot

From: Fabio Estevam <fabio.estevam@freescale.com>

get_board_rev() just returns the cpu revision, which does not make it really 
useful for distinguishing between revisions of the board.

Let's get rid of get_board_rev() as it is not being used with its correct 
meaning.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx6slevk/mx6slevk.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
index 3834eec..838ea6c 100644
--- a/board/freescale/mx6slevk/mx6slevk.c
+++ b/board/freescale/mx6slevk/mx6slevk.c
@@ -308,11 +308,6 @@ int board_init(void)
 	return 0;
 }
 
-u32 get_board_rev(void)
-{
-	return get_cpu_rev();
-}
-
 int checkboard(void)
 {
 	puts("Board: MX6SLEVK\n");
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] mx6slevk: Remove get_board_rev()
  2014-12-29 20:05 [U-Boot] [PATCH] mx6slevk: Remove get_board_rev() Fabio Estevam
@ 2014-12-30 13:37 ` Stefano Babic
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Babic @ 2014-12-30 13:37 UTC (permalink / raw)
  To: u-boot

On 29/12/2014 21:05, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> get_board_rev() just returns the cpu revision, which does not make it really 
> useful for distinguishing between revisions of the board.
> 
> Let's get rid of get_board_rev() as it is not being used with its correct 
> meaning.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx6slevk/mx6slevk.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/board/freescale/mx6slevk/mx6slevk.c b/board/freescale/mx6slevk/mx6slevk.c
> index 3834eec..838ea6c 100644
> --- a/board/freescale/mx6slevk/mx6slevk.c
> +++ b/board/freescale/mx6slevk/mx6slevk.c
> @@ -308,11 +308,6 @@ int board_init(void)
>  	return 0;
>  }
>  
> -u32 get_board_rev(void)
> -{
> -	return get_cpu_rev();
> -}
> -
>  int checkboard(void)
>  {
>  	puts("Board: MX6SLEVK\n");
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-30 13:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-29 20:05 [U-Boot] [PATCH] mx6slevk: Remove get_board_rev() Fabio Estevam
2014-12-30 13:37 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox