From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Wed, 31 Dec 2014 12:27:25 +0100 Subject: [U-Boot] [PATCH] sun7i: Add new Bananapro board / defconfig In-Reply-To: <1420022531.13595.194.camel@hellion.org.uk> References: <1420022295-11794-1-git-send-email-hdegoede@redhat.com> <1420022531.13595.194.camel@hellion.org.uk> Message-ID: <54A3DD9D.6070105@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 31-12-14 11:42, Ian Campbell wrote: > On Wed, 2014-12-31 at 11:38 +0100, Hans de Goede wrote: >> Add support for the new Bananapro A20 development board from lemaker.org. >> This board features 1G RAM, 2 USB A receptacles, 1 micro USB receptacle for >> OTG, 1 micro USB receptacle for power, HDMI, sata, Gbit ethernet, ir receiver, >> 3.5 mm jack for a/v out, on board microphone, 40 gpio pins and sdio wifi. >> >> Signed-off-by: Hans de Goede > > Acked-by: Ian Campbell > >> -#ifdef CONFIG_TARGET_BANANAPI >> +#if defined CONFIG_TARGET_BANANAPI || defined CONFIG_TARGET_BANANAPRO >> setbits_le32(&ccm->gmac_clk_cfg, 0x3 << 10); > > Did we ever get to the bottom of what this was? Yes it sets the TX clock delay chain, which is something which one typically need to do for RGMII phy-s, why this is not needed on the cubietruck is not known / clear. > I take it that you've confirmed it is needed for the pro, rather than > just carrying it over? I've not tested the gmac myself yet, but this is being done by their own u-boot port for the pro in their lemaker github account. Regards, Hans