[U-Boot] [PATCH] sun7i: Add new Bananapro board / defconfig

[U-Boot] [PATCH] sun7i: Add new Bananapro board / defconfig

[Hans de Goede]

Add support for the new Bananapro A20 development board from lemaker.org.
This board features 1G RAM, 2 USB A receptacles, 1 micro USB receptacle for
OTG, 1 micro USB receptacle for power, HDMI, sata, Gbit ethernet, ir receiver,
3.5 mm jack for a/v out, on board microphone, 40 gpio pins and sdio wifi.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 board/sunxi/Kconfig         | 4 ++++
 board/sunxi/Makefile        | 1 +
 board/sunxi/gmac.c          | 2 +-
 configs/Bananapro_defconfig | 9 +++++++++
 4 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 configs/Bananapro_defconfig

diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
index 0cbfb26..8782394 100644
--- a/board/sunxi/Kconfig
+++ b/board/sunxi/Kconfig
@@ -97,6 +97,10 @@ config TARGET_BANANAPI
 	bool "BANANAPI"
 	depends on MACH_SUN7I
 
+config TARGET_BANANAPRO
+	bool "BANANAPRO"
+	depends on MACH_SUN7I
+
 config TARGET_COLOMBUS
 	bool "COLOMBUS"
 	depends on MACH_SUN6I
diff --git a/board/sunxi/Makefile b/board/sunxi/Makefile
index 97aff10..8ca01f6 100644
--- a/board/sunxi/Makefile
+++ b/board/sunxi/Makefile
@@ -22,6 +22,7 @@ obj-$(CONFIG_TARGET_A20_OLINUXINO_M)	+= dram_sun7i_384_1024_iow16.o
 obj-$(CONFIG_TARGET_AUXTEK_T004)	+= dram_a10s_olinuxino_m.o
 obj-$(CONFIG_TARGET_BA10_TV_BOX)	+= dram_sun4i_384_1024_iow8.o
 obj-$(CONFIG_TARGET_BANANAPI)		+= dram_bananapi.o
+obj-$(CONFIG_TARGET_BANANAPRO)		+= dram_bananapi.o
 obj-$(CONFIG_TARGET_CUBIEBOARD)		+= dram_cubieboard.o
 obj-$(CONFIG_TARGET_CUBIEBOARD2)	+= dram_cubieboard2.o
 obj-$(CONFIG_TARGET_CUBIETRUCK)		+= dram_cubietruck.o
diff --git a/board/sunxi/gmac.c b/board/sunxi/gmac.c
index 571bc9e..4e4615e 100644
--- a/board/sunxi/gmac.c
+++ b/board/sunxi/gmac.c
@@ -34,7 +34,7 @@ int sunxi_gmac_initialize(bd_t *bis)
 	 * need to set bits 10-12 GTXDC "GMAC Transmit Clock Delay Chain"
 	 * of the GMAC clk register to 3.
 	 */
-#ifdef CONFIG_TARGET_BANANAPI
+#if defined CONFIG_TARGET_BANANAPI || defined CONFIG_TARGET_BANANAPRO
 	setbits_le32(&ccm->gmac_clk_cfg, 0x3 << 10);
 #endif
 
diff --git a/configs/Bananapro_defconfig b/configs/Bananapro_defconfig
new file mode 100644
index 0000000..7f9ce13
--- /dev/null
+++ b/configs/Bananapro_defconfig
@@ -0,0 +1,9 @@
+CONFIG_SPL=y
+CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_GMAC,RGMII,MACPWR=SUNXI_GPH(23),AHCI,USB_EHCI"
+CONFIG_FDTFILE="sun7i-a20-bananapro.dtb"
+CONFIG_USB1_VBUS_PIN="PH0"
+CONFIG_USB2_VBUS_PIN="PH1"
++S:CONFIG_ARM=y
++S:CONFIG_ARCH_SUNXI=y
++S:CONFIG_MACH_SUN7I=y
++S:CONFIG_TARGET_BANANAPRO=y
-- 
2.1.0

[U-Boot] [PATCH] sun7i: Add new Bananapro board / defconfig

[Ian Campbell]

On Wed, 2014-12-31 at 11:38 +0100, Hans de Goede wrote:
> Add support for the new Bananapro A20 development board from lemaker.org.
> This board features 1G RAM, 2 USB A receptacles, 1 micro USB receptacle for
> OTG, 1 micro USB receptacle for power, HDMI, sata, Gbit ethernet, ir receiver,
> 3.5 mm jack for a/v out, on board microphone, 40 gpio pins and sdio wifi.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> -#ifdef CONFIG_TARGET_BANANAPI
> +#if defined CONFIG_TARGET_BANANAPI || defined CONFIG_TARGET_BANANAPRO
>  	setbits_le32(&ccm->gmac_clk_cfg, 0x3 << 10);

Did we ever get to the bottom of what this was?

I take it that you've confirmed it is needed for the pro, rather than
just carrying it over?

Ian.

[U-Boot] [PATCH] sun7i: Add new Bananapro board / defconfig

[Hans de Goede]

Hi,

On 31-12-14 11:42, Ian Campbell wrote:
> On Wed, 2014-12-31 at 11:38 +0100, Hans de Goede wrote:
>> Add support for the new Bananapro A20 development board from lemaker.org.
>> This board features 1G RAM, 2 USB A receptacles, 1 micro USB receptacle for
>> OTG, 1 micro USB receptacle for power, HDMI, sata, Gbit ethernet, ir receiver,
>> 3.5 mm jack for a/v out, on board microphone, 40 gpio pins and sdio wifi.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>
>> -#ifdef CONFIG_TARGET_BANANAPI
>> +#if defined CONFIG_TARGET_BANANAPI || defined CONFIG_TARGET_BANANAPRO
>>   	setbits_le32(&ccm->gmac_clk_cfg, 0x3 << 10);
>
> Did we ever get to the bottom of what this was?

Yes it sets the TX clock delay chain, which is something which one
typically need to do for RGMII phy-s, why this is not needed on the
cubietruck is not known / clear.

> I take it that you've confirmed it is needed for the pro, rather than
> just carrying it over?

I've not tested the gmac myself yet, but this is being done by their own
u-boot port for the pro in their lemaker github account.

Regards,

Hans

[U-Boot] [PATCH] sun7i: Add new Bananapro board / defconfig

[Hans de Goede]

Hi,

On 31-12-14 11:42, Ian Campbell wrote:
> On Wed, 2014-12-31 at 11:38 +0100, Hans de Goede wrote:
>> Add support for the new Bananapro A20 development board from lemaker.org.
>> This board features 1G RAM, 2 USB A receptacles, 1 micro USB receptacle for
>> OTG, 1 micro USB receptacle for power, HDMI, sata, Gbit ethernet, ir receiver,
>> 3.5 mm jack for a/v out, on board microphone, 40 gpio pins and sdio wifi.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>

Thanks, I've rebased u-boot-sunxi/next to the latest master, squashed the
sun6i m / k pll5 fix into the original commit as you suggested, added this
patch and done a forced push with the result.

If you plan to add Jan Kiszka's patches to next (which I think is a good
idea), please base them on top of what I've just pushed.

Thanks & Regards,

Hans