[U-Boot] [PATCH] mtd: nand: omap_gpmc: fix error handling

[U-Boot] [PATCH] mtd: nand: omap_gpmc: fix error handling

[Guido Martínez]

"err" was an unsigned variable, causing negative error codes to turn
into positive values, which are interpreted as an amount of succesfully
corrected bitflips (and thus not an error).

In particular, this resulted in that if the elm reports uncorrectable
errors (-EBADMSG), the MTD layer (and UBI) falsely succeeded.

Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
---
 drivers/mtd/nand/omap_gpmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/omap_gpmc.c b/drivers/mtd/nand/omap_gpmc.c
index 93829a4..459904d 100644
--- a/drivers/mtd/nand/omap_gpmc.c
+++ b/drivers/mtd/nand/omap_gpmc.c
@@ -368,8 +368,9 @@ static int omap_correct_data_bch(struct mtd_info *mtd, uint8_t *dat,
 	uint32_t error_loc[ELM_MAX_ERROR_COUNT];
 	enum bch_level bch_type;
 	uint32_t i, ecc_flag = 0;
-	uint8_t count, err = 0;
+	uint8_t count;
 	uint32_t byte_pos, bit_pos;
+	int err = 0;
 
 	/* check calculated ecc */
 	for (i = 0; i < ecc->bytes && !ecc_flag; i++) {
-- 
2.1.4

[U-Boot] [PATCH] mtd: nand: omap_gpmc: fix error handling

[Stefan Roese]

On 02.01.2015 18:49, Guido Mart?nez wrote:
> "err" was an unsigned variable, causing negative error codes to turn
> into positive values, which are interpreted as an amount of succesfully
> corrected bitflips (and thus not an error).
>
> In particular, this resulted in that if the elm reports uncorrectable
> errors (-EBADMSG), the MTD layer (and UBI) falsely succeeded.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

[U-Boot] mtd: nand: omap_gpmc: fix error handling

[Tom Rini]

On Fri, Jan 02, 2015 at 02:49:10PM -0300, Guido Mart?nez wrote:

> "err" was an unsigned variable, causing negative error codes to turn
> into positive values, which are interpreted as an amount of succesfully
> corrected bitflips (and thus not an error).
> 
> In particular, this resulted in that if the elm reports uncorrectable
> errors (-EBADMSG), the MTD layer (and UBI) falsely succeeded.
> 
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150107/35cc64b8/attachment.pgp>