From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Sat, 03 Jan 2015 07:02:32 +0100 Subject: [U-Boot] [PATCH] mtd: nand: omap_gpmc: fix error handling In-Reply-To: <1420220950-30463-1-git-send-email-guido@vanguardiasur.com.ar> References: <1420220950-30463-1-git-send-email-guido@vanguardiasur.com.ar> Message-ID: <54A785F8.70606@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02.01.2015 18:49, Guido Mart?nez wrote: > "err" was an unsigned variable, causing negative error codes to turn > into positive values, which are interpreted as an amount of succesfully > corrected bitflips (and thus not an error). > > In particular, this resulted in that if the elm reports uncorrectable > errors (-EBADMSG), the MTD layer (and UBI) falsely succeeded. > > Signed-off-by: Guido Mart?nez Reviewed-by: Stefan Roese Thanks, Stefan