From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] ARM: atmel: at91sam9m10g45ek: enable SPL
Date: Mon, 5 Jan 2015 16:19:46 +0800 [thread overview]
Message-ID: <54AA4922.40205@atmel.com> (raw)
In-Reply-To: <54AA4474.5020302@denx.de>
Hi Heiko,
On 01/05/2015 03:59 PM, Heiko Schocher wrote:
>> +#ifdef CONFIG_SKIP_LOWLEVEL_INIT
>> void spl_board_init(void)
>> +#else
>> +void s_init(void)
>> +#endif
>> {
>> struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
>
> ... and adding this "ifdefs" could be prevented ...
>
> What do you think?
>
> Ah! you wrote:
>
> > As the boot from SD/MMC card with FAT file system, the BSS
> > segment is too big to fit into SRAM, so, use the lds to put
> > it into SDRAM. So, we need to initialize the SDRAM as soon
> > as possible. Borrow the low level init code from
> > <arm/arm/cpu/armv7/lowlevel_init.S> for this purpose.
>
> Hmm... maybe we can include this in the existing code? So we
The existed code is located in <arch/arm/cpu/armv7> directory, I think
it is difficult to include it.
I think we can put it into <arch/arm/cpu/arm926ejs> directory, I am not
sure it will help others. As other SoC has low level init code. Or, as
the patch, put it into <arch/arm/cpu/arm926ejs/at91> directory for at91
series only.
> have BSS for all at91 boards in RAM?
It depends, we still can put the BSS into SRAM use the common
u-boot-spl.lds.
Only put BSS into SDRAM/DDR, when use u-boot-spl-arm9.lds.
> Or, if not possible, we should convert the existing boards into
> your framework ... if you can prepare such a patch I can test it
> on the corvus, taurus and axm boards ...
If the upper method for low level initialize code is chosen, I will
prepare such patch for the boards you mentioned.
> bye,
> Heiko
Best Regards,
Bo Shen
next prev parent reply other threads:[~2015-01-05 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 7:53 [U-Boot] [RFC PATCH] ARM: atmel: at91sam9m10g45ek: enable SPL Bo Shen
2015-01-05 7:59 ` Heiko Schocher
2015-01-05 8:19 ` Bo Shen [this message]
2015-01-05 8:46 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AA4922.40205@atmel.com \
--to=voice.shen@atmel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox