From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] distro_distro_bootcmd: use CONFIG_BOOTCOMMAND instead of setting bootcmd=
Date: Mon, 05 Jan 2015 13:31:15 -0700 [thread overview]
Message-ID: <54AAF493.1070106@wwwdotorg.org> (raw)
In-Reply-To: <1420478019-18877-5-git-send-email-sjoerd.simons@collabora.co.uk>
On 01/05/2015 10:13 AM, Sjoerd Simons wrote:
> Move the bootcmd commands into a seperate distro_bootcmd environment
> variable. Allowing a user to easily launch the distro boot sequence if
> the default bootcmd did not default to distro boot commands.
Well, the user can just type "boot" or "run bootcmd", so I don't think
this makes it much easier for the user:-P
> Also set CONFIG_BOOTCOMMAND to "run distro_bootcmd" if it hasn't been
> configured yet rather then putting it directly in the environment. This
> allows boards to make the distro boot commands available without
> necessarily default to them or to use them as a fallback after running
> some board specific commands instead.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
As an aside, I actually have a local commit that amends the bootcmd
value to include BOOTENV_HOOK_BOOTCMD_PRE before the current value,
which also allows boards to do arbitrary things before executing the
distro boot code. Still, I think your way is more flexible, since it
allows board-provided scripts to invoke $distro_bootcmd when/whereever
they want. I'll rework my code on top of this.
next prev parent reply other threads:[~2015-01-05 20:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 17:13 [U-Boot] [PATCH 0/4] Let the distro boot command scan all partitions Sjoerd Simons
2015-01-05 17:13 ` [U-Boot] [PATCH 1/4] fs: Add command to retrieve the filesystem type Sjoerd Simons
2015-01-05 20:18 ` Stephen Warren
2015-01-06 16:40 ` Sjoerd Simons
2015-01-06 17:05 ` Stephen Warren
2015-02-02 18:57 ` [U-Boot] [U-Boot, " Tom Rini
2015-01-05 17:13 ` [U-Boot] [PATCH 2/4] part: let list put the list in an environment variable Sjoerd Simons
2015-01-05 20:21 ` Stephen Warren
2015-02-02 18:57 ` [U-Boot] [U-Boot, " Tom Rini
2015-01-05 17:13 ` [U-Boot] [PATCH 3/4] config_distro_bootcmd: Scan all partitions for boot files Sjoerd Simons
2015-01-05 20:24 ` Stephen Warren
2015-01-06 17:07 ` Sjoerd Simons
2015-01-07 0:43 ` Stephen Warren
2015-01-07 10:10 ` Sjoerd Simons
2015-01-07 10:22 ` Ian Campbell
2015-01-07 11:01 ` Sjoerd Simons
2015-01-07 11:17 ` Ian Campbell
2015-01-07 11:46 ` Sjoerd Simons
2015-01-07 12:47 ` Ian Campbell
2015-01-10 18:34 ` Dennis Gilmore
2015-01-07 20:22 ` Stephen Warren
2015-01-08 9:24 ` Sjoerd Simons
2015-01-07 20:19 ` Stephen Warren
2015-01-10 18:27 ` Dennis Gilmore
2015-01-12 17:42 ` Stephen Warren
2015-01-12 18:44 ` Dennis Gilmore
2015-01-13 8:40 ` Sjoerd Simons
2015-01-13 20:52 ` Stephen Warren
2015-02-02 18:57 ` [U-Boot] [U-Boot, " Tom Rini
2015-01-05 17:13 ` [U-Boot] [PATCH 4/4] distro_distro_bootcmd: use CONFIG_BOOTCOMMAND instead of setting bootcmd= Sjoerd Simons
2015-01-05 20:31 ` Stephen Warren [this message]
2015-01-06 16:26 ` Sjoerd Simons
2015-02-02 18:57 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AAF493.1070106@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox