[U-Boot] [PATCH v2015.01 fix] sunxi: axp221: Fix using the wrong register address for ALDO2

[U-Boot] [PATCH v2015.01 fix] sunxi: axp221: Fix using the wrong register address for ALDO2

[Hans de Goede]

Hi Ian (et al),

Trivial patch fixing an important bug for the new sun6i / axp221 support in
v2015.01, if someone can give me a quick ack, then I'll send a pull-req to
Tom to get this included in v2015.01.

Thanks & Regards,

Hans

[U-Boot] [PATCH] sunxi: axp221: Fix using the wrong register address for ALDO2

[Hans de Goede]

This fixes us never programming ALDO2, and programming the ALDO2 voltage
into ALDo1.

Reported-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 include/axp221.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/axp221.h b/include/axp221.h
index a6e52e3..e9552f6 100644
--- a/include/axp221.h
+++ b/include/axp221.h
@@ -43,7 +43,7 @@
 #define AXP221_DCDC4_CTRL	0x24
 #define AXP221_DCDC5_CTRL	0x25
 #define AXP221_ALDO1_CTRL	0x28
-#define AXP221_ALDO2_CTRL	0x28
+#define AXP221_ALDO2_CTRL	0x29
 #define AXP221_ALDO3_CTRL	0x2a
 #define AXP221_PAGE		0xff
 
-- 
2.1.0

[U-Boot] [PATCH] sunxi: axp221: Fix using the wrong register address for ALDO2

[Ian Campbell]

On Mon, 2015-01-05 at 17:18 +0100, Hans de Goede wrote:
> This fixes us never programming ALDO2, and programming the ALDO2 voltage
> into ALDo1.
> 
> Reported-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> ---
>  include/axp221.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/axp221.h b/include/axp221.h
> index a6e52e3..e9552f6 100644
> --- a/include/axp221.h
> +++ b/include/axp221.h
> @@ -43,7 +43,7 @@
>  #define AXP221_DCDC4_CTRL	0x24
>  #define AXP221_DCDC5_CTRL	0x25
>  #define AXP221_ALDO1_CTRL	0x28
> -#define AXP221_ALDO2_CTRL	0x28
> +#define AXP221_ALDO2_CTRL	0x29
>  #define AXP221_ALDO3_CTRL	0x2a
>  #define AXP221_PAGE		0xff
>  

[U-Boot] [PATCH] sunxi: axp221: Fix using the wrong register address for ALDO2

[Hans de Goede]

Hi,

On 05-01-15 18:09, Ian Campbell wrote:
> On Mon, 2015-01-05 at 17:18 +0100, Hans de Goede wrote:
>> This fixes us never programming ALDO2, and programming the ALDO2 voltage
>> into ALDo1.
>>
>> Reported-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>

Thanks I've just send out a pull-req for v2015.01 with this fix in,
I just realized I forgot to amend the commit message with your Acked-by
though, ah well.

Regards,

Hans