From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 06 Jan 2015 10:05:15 -0700 Subject: [U-Boot] [PATCH 1/4] fs: Add command to retrieve the filesystem type In-Reply-To: <1420562423.15910.150.camel@collabora.co.uk> References: <1420478019-18877-1-git-send-email-sjoerd.simons@collabora.co.uk> <1420478019-18877-2-git-send-email-sjoerd.simons@collabora.co.uk> <54AAF191.1000002@wwwdotorg.org> <1420562423.15910.150.camel@collabora.co.uk> Message-ID: <54AC15CB.1090004@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/06/2015 09:40 AM, Sjoerd Simons wrote: > On Mon, 2015-01-05 at 13:18 -0700, Stephen Warren wrote: >> On 01/05/2015 10:13 AM, Sjoerd Simons wrote: >>> New command to determine the filesystem type of a given partition. >>> Optionally stores the filesystem type in a environment variable. >> >>> diff --git a/common/cmd_fs.c b/common/cmd_fs.c >> >>> +U_BOOT_CMD( >>> + fstype, 4, 1, do_fstype_wrapper, >>> + "Look up a filesystem type", >>> + " :\n" >> >> Should this line ... >> >>> + "- print filesystem type\n" >>> + "fstype : \n" >> >> ... be consistent with this one - namely either both or neither include >> "fstype" at the start? > > Nope, the cmd_usage implementation does (summarized): > > printf("Usage:\n%s ", cmdtp->name); > puts(cmdtp->help); > putc('\n'); > > So the "fstype" at the start of the first line gets added by that code, > hence the declaration needs to be inconsistent to have a consistent > output for the user :) Ah right. In that case, Reviewed-by: Stephen Warren