[U-Boot] [PATCH 3/4] config_distro_bootcmd: Scan all partitions for boot files

Stephen Warren
2015-01-05T20:24:34Z

On 01/05/2015 10:13 AM, Sjoerd Simons wrote:
> Not all devices use the convention that the boot scripts are on the
> first partition. For example on chromebooks it seems common for the
> first two partitions to be ChromeOS kernel partitions.
>
> So instead of just the first partition scan all partitions on a device
> with a filesystem u-boot can recognize.

I had planned (but obviously never got around to...) enhancing the
scripts to look up the (set of?) bootable partition(s) on the disk and
to attempt to load the boot files from there. Bootable would be defined
as the MBR bootable flag, or GPT legacy bootable attribute.

That would allow the code to zero in on the one specific partition that
it was supposed to look at, rather than searching all partitions.

Do you have any thoughts re: which option is better?

This patch looks fine assuming this option (rather than bootable flag)
is selected.