From: Joonyoung Shim <jy0922.shim@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] Odroid XU3 support additions
Date: Wed, 07 Jan 2015 20:49:00 +0900 [thread overview]
Message-ID: <54AD1D2C.6070202@samsung.com> (raw)
In-Reply-To: <1420622701.15910.180.camel@collabora.co.uk>
Hi Sjoerd,
On 01/07/2015 06:25 PM, Sjoerd Simons wrote:
> On Wed, 2015-01-07 at 17:31 +0900, Joonyoung Shim wrote:
>> Hi,
>>
>> On 12/02/2014 10:56 AM, Hyungwon Hwang wrote:
>>> Dear Sjoerd,
>>>
>>> Thanks for this work. I think it is better to squash patch #1, #3, #4
>>> into my patchs, because these patches remove the code which needlessly
>>> being added by my patches. I will include patch #2 also from next
>>> version.
>>>
>>> On Mon, 01 Dec 2014 13:34:16 +0100
>>> Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote:
>>>
>>>> Hey Hyungwon,
>>>>
>>>> The following are some of the patches i had locally on top of your v9
>>>> Odroid. Feel free to merge them into your patchset (or squash them
>>>> into your existing patches) if they look good to you.
>>>>
>>>> Sjoerd Simons (4):
>>>> Odroid-XU3: Drop redundant fields
>>>> Odroid-XU3: Add entry for DTS EHCI GPIO
>>>> ODROID-XU3: Make odroid-xu3 an smdk5420 variant
>>
>> I need to support odroid xu3 specific gpio setting e.g. to reset emmc
>> for reset command support. Also there are specific gpio setting codes
>> for only smdk5420 board on board/samsung/smdk5420/smdk5420.c and they
>> are not related with odroid xu3 board.
>>
>> So i think that need to split them.
>
> For the gpio specific to the smdk5420 are you referring to the usb vbus
> gpio ? (For which i've dropped the code in a later, merged commit as
> it's handled by common code).
I just mean current remaining - lcd and pwm codes, but maybe can move
them to device tree.
>
>> First, split board file. It's easiest way to make separate board
>> directory.
>>
>> Second, we can make just board file for odroid xu3 in same directory and
>> we should distinguish them from Makefile but i don't know this is
>> general way.
>>
>> Third, using same board file like now but we will need any way to
>> distinguish boards on runtime.
>
> To distinguish boards at runtime you should use the information from the
> DT file of the board rather then hardcoding it in a board file.
>
OK, let's try to use device tree.
Thanks for guide.
prev parent reply other threads:[~2015-01-07 11:49 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 13:21 [U-Boot] [PATCH v9 0/3] Adds support for Exynos5422 odroid xu3 board Hyungwon Hwang
2014-11-27 13:21 ` [U-Boot] [PATCH v9 1/2] Odroid-XU3: Add support for Odroid-XU3 Hyungwon Hwang
2014-11-27 15:16 ` Jaehoon Chung
2014-11-28 1:44 ` Hyungwon Hwang
2014-11-27 16:35 ` Sjoerd Simons
2014-11-28 5:00 ` Hyungwon Hwang
2014-11-28 7:44 ` Sjoerd Simons
2014-11-27 21:45 ` Sjoerd Simons
2014-11-28 2:13 ` Hyungwon Hwang
2014-11-28 8:14 ` Sjoerd Simons
2014-11-28 8:54 ` Jaehoon Chung
2014-12-03 11:34 ` Sjoerd Simons
2014-12-01 17:30 ` Simon Glass
2014-12-02 1:38 ` Hyungwon Hwang
2014-11-27 13:21 ` [U-Boot] [PATCH v9 2/2] Odroid-XU3: Add documentation " Hyungwon Hwang
2014-11-27 14:33 ` Sjoerd Simons
2014-11-28 4:45 ` Hyungwon Hwang
2014-11-28 8:00 ` Sjoerd Simons
2014-11-28 8:39 ` Lukasz Majewski
2014-11-28 10:19 ` Sjoerd Simons
2014-11-28 12:47 ` Lukasz Majewski
2014-11-28 13:31 ` Sjoerd Simons
2014-11-28 11:44 ` Javier Martinez Canillas
2014-11-28 13:46 ` Lukasz Majewski
2014-11-28 15:06 ` Sjoerd Simons
2014-11-29 17:12 ` Lukasz Majewski
2014-12-01 22:30 ` Simon Glass
2014-12-02 22:29 ` Lukasz Majewski
2014-12-02 23:26 ` Suriyan Ramasami
2014-12-08 17:58 ` Kevin Hilman
2014-12-08 22:31 ` Simon Glass
2014-12-09 1:27 ` Kevin Hilman
2014-12-09 13:15 ` Simon Glass
2014-12-10 0:03 ` Kevin Hilman
2014-12-10 0:11 ` Simon Glass
2014-12-10 19:20 ` Kevin Hilman
2014-12-11 1:13 ` Hyungwon Hwang
2014-12-09 10:05 ` Lukasz Majewski
2014-11-27 15:20 ` Jaehoon Chung
2014-12-01 12:34 ` [U-Boot] [PATCH 0/4] Odroid XU3 support additions Sjoerd Simons
2014-12-01 12:34 ` [U-Boot] [PATCH 1/4] Odroid-XU3: Drop redundant fields Sjoerd Simons
2014-12-01 12:34 ` [U-Boot] [PATCH 2/4] Odroid-XU3: Add entry for DTS EHCI GPIO Sjoerd Simons
2014-12-01 12:34 ` [U-Boot] [PATCH 3/4] ODROID-XU3: Make odroid-xu3 an smdk5420 variant Sjoerd Simons
2014-12-01 12:34 ` [U-Boot] [PATCH 4/4] ODROID-XU3: drop overriding the boot environment Sjoerd Simons
2014-12-02 1:56 ` [U-Boot] [PATCH 0/4] Odroid XU3 support additions Hyungwon Hwang
2015-01-07 8:31 ` Joonyoung Shim
2015-01-07 9:25 ` Sjoerd Simons
2015-01-07 11:49 ` Joonyoung Shim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD1D2C.6070202@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox