public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] sunxi: video: Add support for Hitachi tx18d42vm LCD panels
Date: Wed, 07 Jan 2015 21:04:06 +0100	[thread overview]
Message-ID: <54AD9136.4090600@redhat.com> (raw)
In-Reply-To: <1420657167.11796.41.camel@hellion.org.uk>

Hi,

On 07-01-15 19:59, Ian Campbell wrote:
> On Sun, 2015-01-04 at 21:05 +0100, Hans de Goede wrote:
>> Hitachi tx18d42vm LCD panels have an onboard controller which needs some
>> initialization via spi for the panel to become functional as a regular LVDS
>> panel.
>
> This doesn't sound terribly sunxi specific, shouldn't
> sunxi_lcd_panel_hitachi_tx18d42vm_init be generic but making use of some
> sort of arch-provided interface for actually talking SPI to the device
> (which may or may not use the generic SPI infra, as your code comment
> talked about)?

You're right it is not sunxi specific, but for now sunxi is the only user
(I've checked) so this seemed simplest, with the idea that it is always
much easier to make something properly generic when there is more then one
user.

I guess I should have put something about this in the commit message :)

Regards,

Hans

  reply	other threads:[~2015-01-07 20:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 20:05 [U-Boot] [PATCH 1/3] sunxi: video: Add lvds support Hans de Goede
2015-01-04 20:05 ` [U-Boot] [PATCH 2/3] sunxi: video: Add support for Hitachi tx18d42vm LCD panels Hans de Goede
2015-01-07 18:59   ` Ian Campbell
2015-01-07 20:04     ` Hans de Goede [this message]
2015-01-08  8:33       ` Ian Campbell
2015-01-08  8:32   ` Ian Campbell
2015-01-08  8:39     ` Hans de Goede
2015-01-08  9:04       ` Ian Campbell
2015-01-04 20:05 ` [U-Boot] [PATCH 3/3] sunxi: Add new Chuwi V7 CW0825 board / defconfig Hans de Goede
2015-01-07 19:00   ` Ian Campbell
2015-01-07 18:56 ` [U-Boot] [PATCH 1/3] sunxi: video: Add lvds support Ian Campbell
2015-01-07 19:58   ` Hans de Goede
2015-01-08  8:36     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD9136.4090600@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox