[U-Boot] [PATCH 1/3] sunxi: video: Add lvds support

Hans de Goede
2015-01-07T19:58:54Z

Hi,

On 07-01-15 19:56, Ian Campbell wrote:
> On Sun, 2015-01-04 at 21:05 +0100, Hans de Goede wrote:
>> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
>> index 8782394..fdb18a4 100644
>> --- a/board/sunxi/Kconfig
>> +++ b/board/sunxi/Kconfig
>> @@ -345,6 +345,20 @@ config VIDEO_LCD_BL_PWM
>> Set the backlight pwm pin for the LCD panel. This takes a string in the
>> format understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
>>
>> +choice
>> + prompt "LCD panel support"
>> + depends on VIDEO
>> + ---help---
>> + Select which type of LCD panel to support.
>> +
>> +config VIDEO_LCD_PANEL_PARALLEL
>> + bool "Generic parallel interface LCD panel"
>
> I don't see any use of this choice, I suppose it is the #else case?

Right, it is the else case in the actual code (for now).

> Are there other (third) options for LCDs?

Yes, see the second patch in this series, and Sairhei has a tablet which
needs something similar (but different) to the second patch.

> Or could this be reworded as a
> boolean rather than a choice? If it's to remain a choice I think it'd be
> better to have explicit #ifdef ..._PARALLEL rather than #else. Maybe an
> #else /* ..._PARALLEL */ style would be an ok compromise though.

I can make either change, looking at the original allwinner kernel code
I guess doing the #ifdef variant makes most sense. I'll respin this when
we know what to do wrt patch 2/3.

Regards,

Hans