[U-Boot] [PATCH 2/3] sunxi: video: Add support for Hitachi tx18d42vm LCD panels

Hans de Goede
2015-01-07T20:04:06Z

Hi,

On 07-01-15 19:59, Ian Campbell wrote:
> On Sun, 2015-01-04 at 21:05 +0100, Hans de Goede wrote:
>> Hitachi tx18d42vm LCD panels have an onboard controller which needs some
>> initialization via spi for the panel to become functional as a regular LVDS
>> panel.
>
> This doesn't sound terribly sunxi specific, shouldn't
> sunxi_lcd_panel_hitachi_tx18d42vm_init be generic but making use of some
> sort of arch-provided interface for actually talking SPI to the device
> (which may or may not use the generic SPI infra, as your code comment
> talked about)?

You're right it is not sunxi specific, but for now sunxi is the only user
(I've checked) so this seemed simplest, with the idea that it is always
much easier to make something properly generic when there is more then one
user.

I guess I should have put something about this in the commit message :)

Regards,

Hans