From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
Date: Wed, 07 Jan 2015 17:19:03 -0700 [thread overview]
Message-ID: <54ADCCF7.6070508@wwwdotorg.org> (raw)
In-Reply-To: <201501080035.08583.marex@denx.de>
On 01/07/2015 04:35 PM, Marek Vasut wrote:
> On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote:
>> On 01/06/2015 06:27 AM, Hans de Goede wrote:
>>> Hi Marek & Stephen,
>>>
>>> As discussed before we've a problem where our standard bootcmds sometimes
>>> scan usb more then once, causing a large boot delay.
>>>
>>> Marek, as discussed with you before, this patch-set tackles this
>>> differently then previous sets, by simply making "usb start" a oneshot
>>> command (atleast until "usb stop" is called).
>>>
>>> Stephen the second patch then modifies config_distro_bootcmd.h to simply
>>> call "usb start" unconditionally, since calling it repeatedly now can be
>>> done without side-effects.
>>>
>>> Assuming you both like these patches, that leaves the question of how to
>>> merge them, they can be merged individually each through your own trees,
>>> or one of you can pick up both of them, I'll leave that to you.
>>
>> Users will have to get used to running "usb reset" rather than "usb
>> start", but I guess that's fine.
>
> Hi!
>
> So why do we not have "usb reset" only, why can we not discard the "usb start"
> altogether?
The whole point is that we need separate commands for:
* usb start: If USB isn't started, start it and scan the bus, else do
nothing.
This is used by automatic scripts that want to ensure that USB is
available, but not force bus rescans over and over.
* usb reset: If USB isn't started, start it. Always rescan the bus.
This is used by the user to force a rescan of the USB bus, if they know
they've plugged in a new device.
>> Should we rename "usb reset" to "usb restart"?
>
> No, let's not mess with the UI any more than we already did.
Well, it might not be such a bad idea if the semantics are changing, to
give people a heads-up?
next prev parent reply other threads:[~2015-01-08 0:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 13:27 [U-Boot] [PATCH 0/2] Fix repeated USB scans problems Hans de Goede
2015-01-06 13:27 ` [U-Boot] [PATCH 1/2] USB: make "usb start" start usb only once Hans de Goede
2015-01-06 13:27 ` [U-Boot] [PATCH 2/2] config_distro_bootcmd.h: Remove unnecessary magic to avoid repeated USB scans Hans de Goede
2015-01-06 17:02 ` [U-Boot] [PATCH 0/2] Fix repeated USB scans problems Stephen Warren
2015-01-07 23:35 ` Marek Vasut
2015-01-08 0:19 ` Stephen Warren [this message]
2015-01-08 8:34 ` Hans de Goede
2015-01-08 16:16 ` Stephen Warren
2015-01-08 17:06 ` Marek Vasut
2015-01-08 17:23 ` Hans de Goede
2015-01-08 17:36 ` Marek Vasut
2015-01-08 17:40 ` Hans de Goede
2015-01-10 0:49 ` Marek Vasut
2015-01-08 10:09 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ADCCF7.6070508@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox