[U-Boot] [PATCH 1/3] sunxi: video: Add lvds support

Ian Campbell
2015-01-08T08:36:00Z

On Wed, 2015-01-07 at 20:58 +0100, Hans de Goede wrote:
> Hi,
>
> On 07-01-15 19:56, Ian Campbell wrote:
> > On Sun, 2015-01-04 at 21:05 +0100, Hans de Goede wrote:
> >> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> >> index 8782394..fdb18a4 100644
> >> --- a/board/sunxi/Kconfig
> >> +++ b/board/sunxi/Kconfig
> >> @@ -345,6 +345,20 @@ config VIDEO_LCD_BL_PWM
> >> Set the backlight pwm pin for the LCD panel. This takes a string in the
> >> format understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
> >>
> >> +choice
> >> + prompt "LCD panel support"
> >> + depends on VIDEO
> >> + ---help---
> >> + Select which type of LCD panel to support.
> >> +
> >> +config VIDEO_LCD_PANEL_PARALLEL
> >> + bool "Generic parallel interface LCD panel"
> >
> > I don't see any use of this choice, I suppose it is the #else case?
>
> Right, it is the else case in the actual code (for now).
>
> > Are there other (third) options for LCDs?
>
> Yes, see the second patch in this series,

I've replied to the second patch again because it doesn't seem right to
put the specific choice of panel under the class of panel choice label.

> and Sairhei has a tablet which
> needs something similar (but different) to the second patch.

I can't find a reference for this, but I suppose it might imply that the
choice of panel should be a Kconfig choice too, just not the same one as
the general class of panel Kconfig choice (IYSWIM).

Ian.