From: Steve Rae <srae@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] gpt: Fix the protective MBR partition size
Date: Thu, 8 Jan 2015 13:23:01 -0800 [thread overview]
Message-ID: <54AEF535.2020405@broadcom.com> (raw)
In-Reply-To: <1420716404-710-1-git-send-email-maxime.ripard@free-electrons.com>
(+ Lukasz)
Interesting - I'll defer to Lukasz...
Thanks, Steve
On 15-01-08 03:26 AM, Maxime Ripard wrote:
> According to the UEFI Spec (Table 16, section 5.2.3 of the version 2.4 Errata
> B), the protective MBR partition record size must be set to the size of the
> disk minus one, in LBAs.
>
> However, the current code was setting the size as the total number of LBAs on
> the disk, resulting in an off-by-one error.
>
> This confused the AM335x ROM code, and will probably confuse other tools as
> well.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> disk/part_efi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disk/part_efi.c b/disk/part_efi.c
> index 612f0926b62b..5ca17c138e96 100644
> --- a/disk/part_efi.c
> +++ b/disk/part_efi.c
> @@ -240,7 +240,7 @@ static int set_protective_mbr(block_dev_desc_t *dev_desc)
> p_mbr->signature = MSDOS_MBR_SIGNATURE;
> p_mbr->partition_record[0].sys_ind = EFI_PMBR_OSTYPE_EFI_GPT;
> p_mbr->partition_record[0].start_sect = 1;
> - p_mbr->partition_record[0].nr_sects = (u32) dev_desc->lba;
> + p_mbr->partition_record[0].nr_sects = (u32) dev_desc->lba - 1;
>
> /* Write MBR sector to the MMC device */
> if (dev_desc->block_write(dev_desc->dev, 0, 1, p_mbr) != 1) {
>
next prev parent reply other threads:[~2015-01-08 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 11:26 [U-Boot] [PATCH] gpt: Fix the protective MBR partition size Maxime Ripard
2015-01-08 21:23 ` Steve Rae [this message]
2015-01-13 8:36 ` Lukasz Majewski
2015-01-09 13:34 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AEF535.2020405@broadcom.com \
--to=srae@broadcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox