public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] Odroid: Add eMMC-reset node on DT
Date: Fri, 09 Jan 2015 16:30:53 +0900	[thread overview]
Message-ID: <54AF83AD.8030503@samsung.com> (raw)
In-Reply-To: <CAPnjgZ3f95AtD_QouT9jxVMPwAOhe-CsZ8rGcBAzLqMr50wL6Q@mail.gmail.com>

+Cc Jaehoon,

On 01/09/2015 03:20 AM, Simon Glass wrote:
> Hi,
> 
> On 7 January 2015 at 22:44, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
>> This needs for special handling of SD4_nRESET_OUT line for eMMC memory
>> to perform complete reboot on Odroid X2/U3 boards.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> ---
>>  arch/arm/dts/exynos4412-odroid.dts | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/dts/exynos4412-odroid.dts b/arch/arm/dts/exynos4412-odroid.dts
>> index ecb3e23..519a7dd 100644
>> --- a/arch/arm/dts/exynos4412-odroid.dts
>> +++ b/arch/arm/dts/exynos4412-odroid.dts
>> @@ -90,4 +90,9 @@
>>                         reg = <0x125B0000 0x100>;
>>                 };
>>         };
>> +
>> +       emmc-reset {
>> +               compatible = "samsung,emmc-reset";
>> +               reset-gpio = <&gpk1 2 0>;
>> +       };
>>  };
> 
> Shouldn't this go in the relevant sdhci node instead of its own node?
> 

Jaehoon, is it reasonable?

Thanks.

  reply	other threads:[~2015-01-09  7:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08  5:44 [U-Boot] [PATCH 1/3] samsung: board: support eMMC reset using DT Joonyoung Shim
2015-01-08  5:44 ` [U-Boot] [PATCH 2/3] Odroid: Add eMMC-reset node on DT Joonyoung Shim
2015-01-08 18:20   ` Simon Glass
2015-01-09  7:30     ` Joonyoung Shim [this message]
2015-01-08  5:44 ` [U-Boot] [PATCH 3/3] Odroid-XU3: " Joonyoung Shim
2015-01-08 18:18 ` [U-Boot] [PATCH 1/3] samsung: board: support eMMC reset using DT Simon Glass
2015-01-09  7:31   ` Joonyoung Shim
2015-01-09  7:48     ` Minkyu Kang
2015-01-09 11:13     ` Jaehoon Chung
2015-01-10  6:53       ` Joonyoung Shim
2015-01-10 17:46         ` Simon Glass
2015-01-12  1:45           ` Jaehoon Chung
2015-01-12  4:45             ` Joonyoung Shim
2015-01-12 15:54               ` Simon Glass
2015-01-08 23:23 ` Sjoerd Simons
2015-01-09  4:21   ` Jaehoon Chung
2015-01-09  7:42     ` Joonyoung Shim
2015-01-09  7:50       ` Sjoerd Simons
2015-01-10  6:41         ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AF83AD.8030503@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox