From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede@redhat.com>
Date: Sat, 10 Jan 2015 14:55:16 +0100
Subject: [U-Boot] [PATCH v2 0/2] sunxi: video: Add lvds support
In-Reply-To: <1420886439.11796.78.camel@hellion.org.uk>
References: <1420746546-19229-1-git-send-email-hdegoede@redhat.com>
	<1420886439.11796.78.camel@hellion.org.uk>
Message-ID: <54B12F44.6030702@redhat.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On 10-01-15 11:40, Ian Campbell wrote:
> On Thu, 2015-01-08 at 20:49 +0100, Hans de Goede wrote:
>> Hi Ian, Anatolij,
>>
>> Here is v2 of the lvds support for sunxi-video. I've reworked how to Kconfig
>> bits are handled as requested by Ian.
>>
>> Anatolij, the second patch in this sets adds support for initializing the
>> lcd controller found on hitachi tx18d42vm lcd panels, this lvds lcd controller
>> needs some poking via a separate spi bus before the panel will do anything.
>>
>> This code is not really sunxi specific, but since sunxi is the only (known)
>> user of such a lcd controller I've chosen to do this in a sunxi specific file
>> for now, with the idea that making the code generic is more easy when we
>> actually have a second user, and thus a better idea of what is needed for a
>> generic implementation. Can we get your ack for this solution? Or let me know
>> if you want me todo something generic right away and then I'll rework the
>> patch.
>
> Anatolij has acked it, so I don't object.
>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>
> Do you think it might be worth doing:
>
> #if definged(CONFIG_VIDEO_LCD_IF_PARALLEL)
> ...
> #elif defined(CONFIG_VIDEO_LCD_IF_LVDS)
> ...
> #else
> #error unknown LCD_IF
> #endif
>
> instead of the independnent #ifdef's, so anyone adding a third option
> gets a warning to think about at each site? (Just a suggestion, not to
> block the patches if you disagree).

Funny I have been thinking the same myself,
I could do that for the current:

#if defined(CONFIG_VIDEO_LCD_IF_PARALLEL)
...
#endif
#if defined(CONFIG_VIDEO_LCD_IF_LVDS)
...
#endif

blocks, but that still leaves a couple of blocks which are just:

#if defined(CONFIG_VIDEO_LCD_IF_LVDS)
...
#endif

So I decided to just keep the same style everywhere.

Regards,

Hans