public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] sunxi: Enable VGA output on Hummingbird A31
Date: Mon, 12 Jan 2015 11:18:54 +0100	[thread overview]
Message-ID: <54B39F8E.10402@redhat.com> (raw)
In-Reply-To: <1421056932-13723-1-git-send-email-wens@csie.org>

Hi,

On 12-01-15 11:02, Chen-Yu Tsai wrote:
> Hi Hans, Ian,
>
> This series enables the VGA output on the Hummingbird A31. The VGA output
> is driven from LCD0, through an external DAC that's powered up by toggling
> pin PH25.

Thanks for working on this!

> Patch 1 allows selecting CONFIG_VIDEO_VGA_VIA_LCD on sun6i and sun8i.
> These 2 platforms do not have builtin TV encoders, and some vendor may
> use an external DAC to support VGA.
>
> Patch 2 adds support for toggling a GPIO pin as part of the video init
> sequence to power up the DAC
>
> Patch 3 updates the Hummingbird A31 defconfig to enable VGA output.
>
> I have one question about the VGA_VIA_LCD code in general. The color depth
> is forced to 18. Is this necessary?

Depends on the DAC-s you're using, so far this was only used with Olinuxino
boards which use 6 bits dacs. If your board has 8 bit dacs then we should
make this configurable. Note that all this does is enable dithering to avoid
color gradients becoming ugly with 6 bits dacs, but with 8 bit dacs we should
disable the dithering (which is done when depth == 24).

> Can we make it configurable? I haven't
> tried displaying pictures so I don't know if it makes a visible difference.
>
> Also with the VGA output on my Hummingbird A31, I get greenish flashing
> pixels where it should be black, like in and between characters. Once
> booted in to the kernel this disappears, and I get a nice console with
> simplefb. Kind of weird.

Weird indeed, could it be that the DAC-s need some power-supply setup which
u-boot does not set up, but your axp221 kernel code does setup ?

Regards,

Hans

  parent reply	other threads:[~2015-01-12 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 10:02 [U-Boot] [PATCH 0/3] sunxi: Enable VGA output on Hummingbird A31 Chen-Yu Tsai
2015-01-12 10:02 ` [U-Boot] [PATCH 1/3] sunxi: video: Allow external DACs for VGA on platforms without TV encoders Chen-Yu Tsai
2015-01-12 10:02 ` [U-Boot] [PATCH 2/3] sunxi: video: Add support for external DAC enable pin Chen-Yu Tsai
2015-01-12 10:19   ` Hans de Goede
2015-01-12 10:51     ` Chen-Yu Tsai
2015-01-12 10:02 ` [U-Boot] [PATCH 3/3] sunxi: Hummingbird_A31_defconfig: Enable VGA output through external DAC Chen-Yu Tsai
2015-01-12 10:18 ` Hans de Goede [this message]
2015-01-12 11:00   ` [U-Boot] [PATCH 0/3] sunxi: Enable VGA output on Hummingbird A31 Chen-Yu Tsai
2015-01-13 11:16 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B39F8E.10402@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox