From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/2] console: Use pre-console buffer to get complete log on all consoles
Date: Mon, 12 Jan 2015 16:45:13 +0100 [thread overview]
Message-ID: <54B3EC09.1030205@redhat.com> (raw)
In-Reply-To: <20150112133050.GN10826@bill-the-cat>
Hi,
On 12-01-15 14:30, Tom Rini wrote:
> On Mon, Jan 12, 2015 at 12:05:57PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> On 08-01-15 08:02, Siarhei Siamashka wrote:
>>> Currently the pre-console buffer can accumulate early log messages
>>> and flush them to the serial console as soon as it becomes available.
>>>
>>> This patch just adds one more pre-console buffer flushing point and
>>> does all the same for the other consoles too. This is particularly
>>> useful for the vga/hdmi/lcd console, where we can see all the older
>>> messages now (except for the log messages from SPL).
>>>
>>> Naturally, we don't want to get an extra copy of the log messages
>>> on the serial console again at the second flushing point, so the
>>> serial console has to be explicitly filtered out.
>>>
>>> Signed-off-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>
>>
>> Thanks for writing this, this is something which I wanted to have
>> for a while now :)
>>
>> Code wise this looks good to me:
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Tom Rini <trini@ti.com>
>
>> I wonder who should pick this patch up though, Tom can you pick
>> this up ?
>
> Throw it through sunxi when you've got the rest of the patches you want
> that really make use of this ready too?
Sure that works for me.
Regards,
Hans
next prev parent reply other threads:[~2015-01-12 15:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 7:02 [U-Boot] [PATCH 1/2] console: Use pre-console buffer to get complete log on all consoles Siarhei Siamashka
2015-01-08 7:02 ` [U-Boot] [PATCH 2/2] sunxi: Enable pre-console buffer Siarhei Siamashka
2015-01-08 8:49 ` Ian Campbell
2015-01-09 11:13 ` Siarhei Siamashka
2015-01-10 10:50 ` Ian Campbell
2015-01-10 15:24 ` Simon Glass
2015-01-11 23:28 ` Siarhei Siamashka
2015-01-12 2:04 ` Simon Glass
2015-01-13 1:17 ` Simon Glass
2015-01-11 23:16 ` Siarhei Siamashka
2015-01-12 10:50 ` Hans de Goede
2015-01-12 11:05 ` [U-Boot] [U-Boot, 1/2] console: Use pre-console buffer to get complete log on all consoles Hans de Goede
2015-01-12 13:30 ` Tom Rini
2015-01-12 15:45 ` Hans de Goede [this message]
2015-01-13 10:59 ` Hans de Goede
2015-01-13 12:36 ` Siarhei Siamashka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B3EC09.1030205@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox