[U-Boot] [PATCH 4/4] distro_distro_bootcmd: use CONFIG_BOOTCOMMAND instead of setting bootcmd=

Sjoerd Simons
2015-01-06T16:26:52Z

On Mon, 2015-01-05 at 13:31 -0700, Stephen Warren wrote:
> On 01/05/2015 10:13 AM, Sjoerd Simons wrote:
> > Move the bootcmd commands into a seperate distro_bootcmd environment
> > variable. Allowing a user to easily launch the distro boot sequence if
> > the default bootcmd did not default to distro boot commands.
>
> Well, the user can just type "boot" or "run bootcmd", so I don't think
> this makes it much easier for the user:-P

What i meant was if the bootcmd environment variable is set to something
different then the distro bootcmds, you can now simply type "run
distro_bootcmd" to get that behaviour :)

> > Also set CONFIG_BOOTCOMMAND to "run distro_bootcmd" if it hasn't been
> > configured yet rather then putting it directly in the environment. This
> > allows boards to make the distro boot commands available without
> > necessarily default to them or to use them as a fallback after running
> > some board specific commands instead.
>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>

Thanks for the review!

> As an aside, I actually have a local commit that amends the bootcmd
> value to include BOOTENV_HOOK_BOOTCMD_PRE before the current value,
> which also allows boards to do arbitrary things before executing the
> distro boot code. Still, I think your way is more flexible, since it
> allows board-provided scripts to invoke $distro_bootcmd when/whereever
> they want. I'll rework my code on top of this.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150106/a2e365f0/attachment.bin>