[U-Boot] [PATCH] ARM: exynos: clock: remove clock_get_periph_rate()

Simon Glass
2015-01-13T04:16:39Z

Hi,

On 7 January 2015 at 23:33, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> This api is wrong array bounds.
>
> arch/arm/cpu/armv7/exynos/clock.c: In function 'clock_get_periph_rate':
> arch/arm/cpu/armv7/exynos/clock.c:265:47: warning: array subscript is above array bounds [-Warray-bounds]
> struct clk_bit_info *bit_info = &clk_bit_info[peripheral];
>
> And it doesn't use anywhere. It only used to get pwm clock.
> So it changes from clock_get_periph_rate() to get_pwm_clock.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> arch/arm/cpu/armv7/exynos/clock.c | 173 +++++----------------------------
> arch/arm/include/asm/arch-exynos/clk.h | 9 --
> 2 files changed, 25 insertions(+), 157 deletions(-)

As discussed on the other patch, can we fix this and use it, rather
than removing it? Lots of little functions for each n peripherals and
each m SoCs = n * m functions and a primitive API.

This was a request made as part of the Snow and Pit developments, but
it didn't get very far. Can we finish it?

Regards,
Simon