[U-Boot] [PATCH 17/17] sunxi: Hookup OTG USB controller support

Hans de Goede
2015-01-14T07:48:15Z

Hi,

On 13-01-15 20:59, Ian Campbell wrote:
> On Sun, 2015-01-11 at 20:34 +0100, Hans de Goede wrote:
>> Hookup OTG USB controller support and enable the otg controller + USB-keyb
>> on various tablets.
>>
>> This allows tablet owners to interact with u-boot without needing to solder
>> a serial console onto their tablet PCB.
>
> Looks good, except I can't for the life of me find where
> CONFIG_MUSB_GADGET is ever set for a sunxi platform.
>
> I suspect it's just there in preparation for some future gadget mode
> work (what we care about here is host mode), is that right?

Right, in theory we have everything in place for gadget mode when this
patch-set lands and all someone needs to do is add a Kconfig option
for it. Note I do not plan to work on that ATM, only so much hours
in a day, etc. but I do invite others who are interested in this
to take a look at the gadget stuff and patches are welcome :)

>
> If so: Acked-by: Ian Campbell <ijc@hellion.org.uk>
>
>> +#if defined(CONFIG_MUSB_HOST) || defined(CONFIG_MUSB_GADGET)
>
> Not just #ifdef CONFIG_USB_MUSB_SUNXI? (Ack either way)

This is the construct the other MUSB users use in their board code,
but yes either would work.

Regards,

Hans