[U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr

public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed

* [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr
@ 2014-10-21 11:36 Ramneek Mehresh
  2014-10-21 11:36 ` [U-Boot] [PATCH] ls1:config: Add XHCI support for ls1021aqds Ramneek Mehresh
  2014-12-17 23:08 ` [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr York Sun
  0 siblings, 2 replies; 6+ messages in thread
From: Ramneek Mehresh @ 2014-10-21 11:36 UTC (permalink / raw)
  To: u-boot

Add USB EHCI/XHCI support for ls1021atwr platform and
making xHCI as default mode

Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
---
 include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h
index 45b2272..109e58c 100644
--- a/include/configs/ls1021atwr.h
+++ b/include/configs/ls1021atwr.h
@@ -28,6 +28,34 @@
 #define CONFIG_SYS_INIT_RAM_SIZE	OCRAM_SIZE
 
 /*
+ * USB
+ */
+/*EHCI Support*/
+/*#define CONFIG_HAS_FSL_DR_USB*/
+
+#ifdef CONFIG_HAS_FSL_DR_USB
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_FSL
+#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
+#endif
+
+/*XHCI Support*/
+#define CONFIG_HAS_FSL_XHCI_USB
+
+#ifdef CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT        1
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS     1
+#endif
+
+#if defined(CONFIG_HAS_FSL_DR_USB) || defined(CONFIG_HAS_FSL_XHCI_USB)
+#define CONFIG_CMD_USB
+#define CONFIG_USB_STORAGE
+#define CONFIG_CMD_EXT2
+#endif
+
+/*
  * Generic Timer Definitions
  */
 #define GENERIC_TIMER_CLK		12500000
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] ls1:config: Add XHCI support for ls1021aqds
  2014-10-21 11:36 [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr Ramneek Mehresh
@ 2014-10-21 11:36 ` Ramneek Mehresh
  2014-12-17 23:07   ` York Sun
  2014-12-17 23:08 ` [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr York Sun
  1 sibling, 1 reply; 6+ messages in thread
From: Ramneek Mehresh @ 2014-10-21 11:36 UTC (permalink / raw)
  To: u-boot

Add USB XHCI support for ls1021aqds platform and
making this as default mode

Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
---
 include/configs/ls1021aqds.h | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/include/configs/ls1021aqds.h b/include/configs/ls1021aqds.h
index fd43a3e..c6f83b2 100644
--- a/include/configs/ls1021aqds.h
+++ b/include/configs/ls1021aqds.h
@@ -275,19 +275,30 @@ unsigned long get_board_ddr_clk(void);
 /*
  * USB
  */
-#define CONFIG_HAS_FSL_DR_USB
+/*EHCI Support*/
+/*#define CONFIG_HAS_FSL_DR_USB*/
 
 #ifdef CONFIG_HAS_FSL_DR_USB
 #define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_FSL
+#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
+#endif
 
-#ifdef CONFIG_USB_EHCI
+/*XHCI Support*/
+#define CONFIG_HAS_FSL_XHCI_USB
+
+#ifdef CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT	1
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	1
+#endif
+
+#if defined(CONFIG_HAS_FSL_DR_USB) || defined(CONFIG_HAS_FSL_XHCI_USB)
 #define CONFIG_CMD_USB
 #define CONFIG_USB_STORAGE
-#define CONFIG_USB_EHCI_FSL
-#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
 #define CONFIG_CMD_EXT2
 #endif
-#endif
 
 /*
  * eTSEC
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] ls1:config: Add XHCI support for ls1021aqds
  2014-10-21 11:36 ` [U-Boot] [PATCH] ls1:config: Add XHCI support for ls1021aqds Ramneek Mehresh
@ 2014-12-17 23:07   ` York Sun
  0 siblings, 0 replies; 6+ messages in thread
From: York Sun @ 2014-12-17 23:07 UTC (permalink / raw)
  To: u-boot

On 10/21/2014 04:36 AM, Ramneek Mehresh wrote:
> Add USB XHCI support for ls1021aqds platform and
> making this as default mode
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> ---
>  include/configs/ls1021aqds.h | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
> 

Please verify this patch on the latest u-boot. I saw compiling errors.

York

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr
  2014-10-21 11:36 [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr Ramneek Mehresh
  2014-10-21 11:36 ` [U-Boot] [PATCH] ls1:config: Add XHCI support for ls1021aqds Ramneek Mehresh
@ 2014-12-17 23:08 ` York Sun
  2015-01-14 18:46   ` York Sun
  1 sibling, 1 reply; 6+ messages in thread
From: York Sun @ 2014-12-17 23:08 UTC (permalink / raw)
  To: u-boot

On 10/21/2014 04:36 AM, Ramneek Mehresh wrote:
> Add USB EHCI/XHCI support for ls1021atwr platform and
> making xHCI as default mode
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> ---
>  include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 

Please verify this patch on the latest u-boot. I saw compiling errors.

York

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr
  2014-12-17 23:08 ` [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr York Sun
@ 2015-01-14 18:46   ` York Sun
  2015-01-15  4:47     ` Ramneek Mehresh
  0 siblings, 1 reply; 6+ messages in thread
From: York Sun @ 2015-01-14 18:46 UTC (permalink / raw)
  To: u-boot



On 12/17/2014 03:08 PM, York Sun wrote:
> On 10/21/2014 04:36 AM, Ramneek Mehresh wrote:
>> Add USB EHCI/XHCI support for ls1021atwr platform and
>> making xHCI as default mode
>>
>> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
>> ---
>>  include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
> 
> Please verify this patch on the latest u-boot. I saw compiling errors.
> 

Please fix. This patch cause compiling errors on all ls1021atwr boards. If this
patch depends on other patches, please put into comment so I can apply them in
order.


+drivers/usb/host/built-in.o: In function `usb_lowlevel_init':
+drivers/usb/host/xhci.c:948: undefined reference to `xhci_hcd_init'
+drivers/usb/host/built-in.o: In function `usb_lowlevel_stop':
+drivers/usb/host/xhci.c:1025: undefined reference to `xhci_hcd_stop'
+arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion fail
../../bfd/elf32-arm.c:7498
+arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion fail
../../bfd/elf32-arm.c:13830
+make[1]: *** [u-boot] Error 139
+make: *** [sub-make] Error 2

York

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr
  2015-01-14 18:46   ` York Sun
@ 2015-01-15  4:47     ` Ramneek Mehresh
  0 siblings, 0 replies; 6+ messages in thread
From: Ramneek Mehresh @ 2015-01-15  4:47 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Sun York-R58495
> Sent: Thursday, January 15, 2015 12:16 AM
> To: Mehresh Ramneek-B31383; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr
> 
> 
> 
> On 12/17/2014 03:08 PM, York Sun wrote:
> > On 10/21/2014 04:36 AM, Ramneek Mehresh wrote:
> >> Add USB EHCI/XHCI support for ls1021atwr platform and making xHCI as
> >> default mode
> >>
> >> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> >> ---
> >>  include/configs/ls1021atwr.h | 28 ++++++++++++++++++++++++++++
> >>  1 file changed, 28 insertions(+)
> >>
> >
> > Please verify this patch on the latest u-boot. I saw compiling errors.
> >
> 
> Please fix. This patch cause compiling errors on all ls1021atwr boards. If this
> patch depends on other patches, please put into comment so I can apply
> them in order.
Hi York, this patch depends on http://patchwork.ozlabs.org/patch/373593/
which is under review, and has comments from Marex. For this patch, we have
dependency on IP team, and that's taking lot of time

> 
> 
> +drivers/usb/host/built-in.o: In function `usb_lowlevel_init':
> +drivers/usb/host/xhci.c:948: undefined reference to `xhci_hcd_init'
> +drivers/usb/host/built-in.o: In function `usb_lowlevel_stop':
> +drivers/usb/host/xhci.c:1025: undefined reference to `xhci_hcd_stop'
> +arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion
> +fail
> ../../bfd/elf32-arm.c:7498
> +arm-linux-gnueabi-ld.bfd: BFD (GNU Binutils for Ubuntu) 2.22 assertion
> +fail
> ../../bfd/elf32-arm.c:13830
> +make[1]: *** [u-boot] Error 139
> +make: *** [sub-make] Error 2
> 
> York

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-01-15  4:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21 11:36 [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr Ramneek Mehresh
2014-10-21 11:36 ` [U-Boot] [PATCH] ls1:config: Add XHCI support for ls1021aqds Ramneek Mehresh
2014-12-17 23:07   ` York Sun
2014-12-17 23:08 ` [U-Boot] [PATCH] ls1:config: Add USB support for ls1021atwr York Sun
2015-01-14 18:46   ` York Sun
2015-01-15  4:47     ` Ramneek Mehresh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox