* [U-Boot] [PATCH] arm: ls102xa: Enable snooping for CCI-400 S0 slave interface
@ 2014-11-13 14:12 Alison Wang
2015-01-14 18:52 ` York Sun
0 siblings, 1 reply; 3+ messages in thread
From: Alison Wang @ 2014-11-13 14:12 UTC (permalink / raw)
To: u-boot
CAAM is connected to CCI-400 S0 slave interface. Disable snooping for
S0 will cause CAAM self test failure. This patch is to enable snooping
for S0 slave interface.
Signed-off-by: Alison Wang <alison.wang@freescale.com>
---
board/freescale/ls1021aqds/ls1021aqds.c | 3 +--
board/freescale/ls1021atwr/ls1021atwr.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/board/freescale/ls1021aqds/ls1021aqds.c b/board/freescale/ls1021aqds/ls1021aqds.c
index 4dda5e3..e5dea5d 100644
--- a/board/freescale/ls1021aqds/ls1021aqds.c
+++ b/board/freescale/ls1021aqds/ls1021aqds.c
@@ -202,10 +202,9 @@ int board_early_init_f(void)
CCI400_DVM_MESSAGE_REQ_EN | CCI400_SNOOP_REQ_EN);
/*
- * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
+ * Set CCI-400 Slave interface S1, S2 Shareable Override Register
* All transactions are treated as non-shareable
*/
- out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
diff --git a/board/freescale/ls1021atwr/ls1021atwr.c b/board/freescale/ls1021atwr/ls1021atwr.c
index 0629d1c..2c8afc0 100644
--- a/board/freescale/ls1021atwr/ls1021atwr.c
+++ b/board/freescale/ls1021atwr/ls1021atwr.c
@@ -419,10 +419,9 @@ int board_init(void)
struct ccsr_cci400 *cci = (struct ccsr_cci400 *)CONFIG_SYS_CCI400_ADDR;
/*
- * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
+ * Set CCI-400 Slave interface S1, S2 Shareable Override Register
* All transactions are treated as non-shareable
*/
- out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
out_le32(0x1185000, 0x3);
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: ls102xa: Enable snooping for CCI-400 S0 slave interface
2014-11-13 14:12 [U-Boot] [PATCH] arm: ls102xa: Enable snooping for CCI-400 S0 slave interface Alison Wang
@ 2015-01-14 18:52 ` York Sun
2015-01-15 9:03 ` Huan Wang
0 siblings, 1 reply; 3+ messages in thread
From: York Sun @ 2015-01-14 18:52 UTC (permalink / raw)
To: u-boot
Alison,
On 11/13/2014 06:12 AM, Alison Wang wrote:
> CAAM is connected to CCI-400 S0 slave interface. Disable snooping for
> S0 will cause CAAM self test failure. This patch is to enable snooping
> for S0 slave interface.
>
> Signed-off-by: Alison Wang <alison.wang@freescale.com>
> ---
> board/freescale/ls1021aqds/ls1021aqds.c | 3 +--
> board/freescale/ls1021atwr/ls1021atwr.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/board/freescale/ls1021aqds/ls1021aqds.c b/board/freescale/ls1021aqds/ls1021aqds.c
> index 4dda5e3..e5dea5d 100644
> --- a/board/freescale/ls1021aqds/ls1021aqds.c
> +++ b/board/freescale/ls1021aqds/ls1021aqds.c
> @@ -202,10 +202,9 @@ int board_early_init_f(void)
> CCI400_DVM_MESSAGE_REQ_EN | CCI400_SNOOP_REQ_EN);
>
> /*
> - * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
> + * Set CCI-400 Slave interface S1, S2 Shareable Override Register
> * All transactions are treated as non-shareable
> */
> - out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
>
> diff --git a/board/freescale/ls1021atwr/ls1021atwr.c b/board/freescale/ls1021atwr/ls1021atwr.c
> index 0629d1c..2c8afc0 100644
> --- a/board/freescale/ls1021atwr/ls1021atwr.c
> +++ b/board/freescale/ls1021atwr/ls1021atwr.c
> @@ -419,10 +419,9 @@ int board_init(void)
> struct ccsr_cci400 *cci = (struct ccsr_cci400 *)CONFIG_SYS_CCI400_ADDR;
>
> /*
> - * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
> + * Set CCI-400 Slave interface S1, S2 Shareable Override Register
> * All transactions are treated as non-shareable
> */
> - out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> out_le32(0x1185000, 0x3);
>
Which patch does this one depend on? The code you remove doesn't exist. Please
check and rebase to latest code if necessary.
York
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: ls102xa: Enable snooping for CCI-400 S0 slave interface
2015-01-14 18:52 ` York Sun
@ 2015-01-15 9:03 ` Huan Wang
0 siblings, 0 replies; 3+ messages in thread
From: Huan Wang @ 2015-01-15 9:03 UTC (permalink / raw)
To: u-boot
Hi, York,
> On 11/13/2014 06:12 AM, Alison Wang wrote:
> > CAAM is connected to CCI-400 S0 slave interface. Disable snooping for
> > S0 will cause CAAM self test failure. This patch is to enable
> snooping
> > for S0 slave interface.
> >
> > Signed-off-by: Alison Wang <alison.wang@freescale.com>
> > ---
> > board/freescale/ls1021aqds/ls1021aqds.c | 3 +--
> > board/freescale/ls1021atwr/ls1021atwr.c | 3 +--
> > 2 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/board/freescale/ls1021aqds/ls1021aqds.c
> > b/board/freescale/ls1021aqds/ls1021aqds.c
> > index 4dda5e3..e5dea5d 100644
> > --- a/board/freescale/ls1021aqds/ls1021aqds.c
> > +++ b/board/freescale/ls1021aqds/ls1021aqds.c
> > @@ -202,10 +202,9 @@ int board_early_init_f(void)
> > CCI400_DVM_MESSAGE_REQ_EN | CCI400_SNOOP_REQ_EN);
> >
> > /*
> > - * Set CCI-400 Slave interface S0, S1, S2 Shareable Override
> Register
> > + * Set CCI-400 Slave interface S1, S2 Shareable Override Register
> > * All transactions are treated as non-shareable
> > */
> > - out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> > out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> > out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> >
> > diff --git a/board/freescale/ls1021atwr/ls1021atwr.c
> > b/board/freescale/ls1021atwr/ls1021atwr.c
> > index 0629d1c..2c8afc0 100644
> > --- a/board/freescale/ls1021atwr/ls1021atwr.c
> > +++ b/board/freescale/ls1021atwr/ls1021atwr.c
> > @@ -419,10 +419,9 @@ int board_init(void)
> > struct ccsr_cci400 *cci = (struct ccsr_cci400
> > *)CONFIG_SYS_CCI400_ADDR;
> >
> > /*
> > - * Set CCI-400 Slave interface S0, S1, S2 Shareable Override
> Register
> > + * Set CCI-400 Slave interface S1, S2 Shareable Override Register
> > * All transactions are treated as non-shareable
> > */
> > - out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> > out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> > out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
> > out_le32(0x1185000, 0x3);
> >
>
> Which patch does this one depend on? The code you remove doesn't exist.
> Please check and rebase to latest code if necessary.
>
[Alison Wang] This patch was based on other patch about deep sleep. I will
rebase and integrate it into another patch. I will abandon this patch.
Thanks.
Best Regards,
Alison Wang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-15 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-13 14:12 [U-Boot] [PATCH] arm: ls102xa: Enable snooping for CCI-400 S0 slave interface Alison Wang
2015-01-14 18:52 ` York Sun
2015-01-15 9:03 ` Huan Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox