[U-Boot] [PATCH] net: Declare physical address as phys_addr_t unsigned type

[U-Boot] [PATCH] net: Declare physical address as phys_addr_t unsigned type

[Michal Simek]

Use phys_addr_t instead of int for addresses.
Addresses can't be < 0.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 include/net.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net.h b/include/net.h
index 18d279ebe737..3da35fe98188 100644
--- a/include/net.h
+++ b/include/net.h
@@ -81,7 +81,7 @@ enum eth_state_t {
 struct eth_device {
 	char name[16];
 	unsigned char enetaddr[6];
-	int iobase;
+	phys_addr_t iobase;
 	int state;

 	int  (*init) (struct eth_device *, bd_t *);
--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150114/7b023f8e/attachment.pgp>

[U-Boot] net: Declare physical address as phys_addr_t unsigned type

[Tom Rini]

On Wed, Jan 14, 2015 at 04:00:39PM +0100, Michal Simek wrote:

> Use phys_addr_t instead of int for addresses.
> Addresses can't be < 0.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Note that this introduces:
w+(microblaze-generic) ../drivers/net/xilinx_ll_temac.c: In function 'll_temac_init':
w+(microblaze-generic) ../drivers/net/xilinx_ll_temac.c:235:3: warning: format '%X' exp

which I know you'll fix soon enough, thanks :)

It also adds:
w+(katmai) ../drivers/net/eepro100.c: In function 'INW':
w+(katmai) ../drivers/net/eepro100.c:243:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
(and for OUTW/OUTL/INL) on katmai.  Stefan, you're currently flagged as
maintainer.  Can you take a stab at this?  Thanks!

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150115/03ddfa48/attachment.pgp>

[U-Boot] net: Declare physical address as phys_addr_t unsigned type

[Michal Simek]

On 01/15/2015 03:59 PM, Tom Rini wrote:
> On Wed, Jan 14, 2015 at 04:00:39PM +0100, Michal Simek wrote:
> 
>> Use phys_addr_t instead of int for addresses.
>> Addresses can't be < 0.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> 
> Note that this introduces:
> w+(microblaze-generic) ../drivers/net/xilinx_ll_temac.c: In function 'll_temac_init':
> w+(microblaze-generic) ../drivers/net/xilinx_ll_temac.c:235:3: warning: format '%X' exp
> 
> which I know you'll fix soon enough, thanks :)

Sent.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150115/38ded799/attachment.pgp>