From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dinh Nguyen <dinguyen@opensource.altera.com>
Date: Thu, 15 Jan 2015 13:19:15 -0600
Subject: [U-Boot] [PATCHv1 15/22] arm: socfpga: spl: add
 relocate_stack_to_sdram to lowlevel_init.S
In-Reply-To: <201501150058.58198.marex@denx.de>
References: <1421253662-27222-1-git-send-email-dinguyen@opensource.altera.com>
	<1421253662-27222-16-git-send-email-dinguyen@opensource.altera.com>
	<201501150058.58198.marex@denx.de>
Message-ID: <54B812B3.6040900@opensource.altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On 01/14/2015 05:58 PM, Marek Vasut wrote:
> On Wednesday, January 14, 2015 at 05:40:55 PM, dinguyen at opensource.altera.com 
> wrote:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Add a function to relocate the stack from OCRAM to SDRAM.
> 
> Hi,
> 
> is this functionality really needed ? There's like 128 KiB of OCRAM on SoCFPGA,

On cyclone5 and arria5, there is only 64KiB.

> which should be plenty, right? If moving the stack to SDRAM is really needed, 
> then you might want to use the common stack relocation code (see relocate_code() 
> function). Also, you should thoroughly describe the reason in the commit 
> message, in this case it's really important.

I'll update in v2.
Thanks,
Dinh