From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: display: Make lcd display clk phase configurable
Date: Sun, 18 Jan 2015 13:21:30 +0100 [thread overview]
Message-ID: <54BBA54A.4010606@redhat.com> (raw)
In-Reply-To: <20150118133352.6fb60d39@i7>
Hi,
On 18-01-15 12:33, Siarhei Siamashka wrote:
> On Tue, 13 Jan 2015 13:33:32 +0100
> Hans de Goede <hdegoede@redhat.com> wrote:
>
>> While running some tests with an Olinuxino-A13-Micro + a 7" Olimex LCD module
>> I noticed that the screen flickered. This is caused by the lcd display clk
>> phase reg value being set to 0, where it should be 1 in this setup.
>>
>> This commit adds a Kconfig option for the lcd display clk phase, so that we
>> can set it per board. This defaults to 1, because looking at all the fex
>> files in sunxi-boards, that is by far the most used value.
>
> What is the name of this option in fex files?
Good question on sun4i / sun5i / sun7i it is stored in lcd_io_cfg0
but as a raw register value, rather then the clk phase value,
so you need to shift right by 28 to get the actual value, e.g.:
lcd_io_cfg0 = 268435456
Means (0x10000000 >> 28) == 1
On sun6i / sun8i it is not clear, the allwinner kernel code uses
lcd_hv_clk_phase which gets converted to an actual register value in a
complicated method unfortunately, see the allwinner kernel sources.
Where as the fex files seem to use lcd_io_phase which is not used by
the kernel AFAICT ...
Looking at the register values used under android it just seems to end
up being 0 on sun6i / sun8i.
Regards,
Hans
prev parent reply other threads:[~2015-01-18 12:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 12:33 [U-Boot] [PATCH] sunxi: display: Make lcd display clk phase configurable Hans de Goede
2015-01-17 23:05 ` Ian Campbell
2015-01-18 3:12 ` Simon Glass
2015-01-19 19:06 ` Hans de Goede
2015-01-19 19:46 ` Simon Glass
2015-01-19 20:10 ` Hans de Goede
2015-01-20 3:26 ` Simon Glass
2015-01-18 11:33 ` Siarhei Siamashka
2015-01-18 12:21 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BBA54A.4010606@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox