[U-Boot] [PATCH v2 1/3] ARM: at91: sama5d3_xplained: save environment in a FAT file in MMC card

[Josh Wu <josh.wu@atmel.com>]

On 1/19/2015 4:16 PM, Bo Shen wrote:
> Hi Josh,
>
> On 01/19/2015 03:06 PM, Josh Wu wrote:
>> This patch will save U-Boot environment as a file: uboot.env, in FAT 
>> partition
>> instead of saving it in raw sector of MMC card.
>>
>> This make us easier to manage the environment file.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>
> After you remove the duplicated definition.
>
> Acked-by: Bo Shen <voice.shen@atmel.com>
Thanks.

>
>> ---
>>
>>   include/configs/sama5d3_xplained.h | 10 ++++++----
>>   1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/configs/sama5d3_xplained.h 
>> b/include/configs/sama5d3_xplained.h
>> index d5588b1..a697035 100644
>> --- a/include/configs/sama5d3_xplained.h
>> +++ b/include/configs/sama5d3_xplained.h
>> @@ -169,13 +169,15 @@
>>                   "bootz 0x22000000 - 0x21000000"
>>   #elif CONFIG_SYS_USE_MMC
>>   /* bootstrap + u-boot + env in sd card */
>> -#define CONFIG_ENV_IS_IN_MMC
>> -#define CONFIG_ENV_OFFSET    0x2000
>> -#define CONFIG_ENV_SIZE        0x1000
>> +#define CONFIG_ENV_IS_IN_FAT
>> +#define CONFIG_FAT_WRITE
>
> This has been defined in
> --->8---
> #if defined(CONFIG_CMD_USB) || defined(CONFIG_CMD_MMC)
> #define CONFIG_CMD_FAT
> #define CONFIG_FAT_WRITE
> ---<8---
Okay, you are right. Will do.

Best Regards,
Josh Wu

>
>> +#define FAT_ENV_INTERFACE    "mmc"
>> +#define FAT_ENV_FILE        "uboot.env"
>> +#define FAT_ENV_DEVICE_AND_PART    "0"
>> +#define CONFIG_ENV_SIZE        0x4000
>>   #define CONFIG_BOOTCOMMAND    "fatload mmc 0:1 0x21000000 
>> at91-sama5d3_xplained.dtb; " \
>>                   "fatload mmc 0:1 0x22000000 zImage; " \
>>                   "bootz 0x22000000 - 0x21000000"
>> -#define CONFIG_SYS_MMC_ENV_DEV    0
>>   #else
>>   #define CONFIG_ENV_IS_NOWHERE
>>   #endif
>>
>
> Best Regards,
> Bo Shen