From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Wu Date: Mon, 19 Jan 2015 16:55:21 +0800 Subject: [U-Boot] [PATCH v2 1/3] ARM: at91: sama5d3_xplained: save environment in a FAT file in MMC card In-Reply-To: <54BCBD43.8080509@atmel.com> References: <1421651212-4382-1-git-send-email-josh.wu@atmel.com> <1421651212-4382-2-git-send-email-josh.wu@atmel.com> <54BCBD43.8080509@atmel.com> Message-ID: <54BCC679.7070107@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 1/19/2015 4:16 PM, Bo Shen wrote: > Hi Josh, > > On 01/19/2015 03:06 PM, Josh Wu wrote: >> This patch will save U-Boot environment as a file: uboot.env, in FAT >> partition >> instead of saving it in raw sector of MMC card. >> >> This make us easier to manage the environment file. >> >> Signed-off-by: Josh Wu > > After you remove the duplicated definition. > > Acked-by: Bo Shen Thanks. > >> --- >> >> include/configs/sama5d3_xplained.h | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/include/configs/sama5d3_xplained.h >> b/include/configs/sama5d3_xplained.h >> index d5588b1..a697035 100644 >> --- a/include/configs/sama5d3_xplained.h >> +++ b/include/configs/sama5d3_xplained.h >> @@ -169,13 +169,15 @@ >> "bootz 0x22000000 - 0x21000000" >> #elif CONFIG_SYS_USE_MMC >> /* bootstrap + u-boot + env in sd card */ >> -#define CONFIG_ENV_IS_IN_MMC >> -#define CONFIG_ENV_OFFSET 0x2000 >> -#define CONFIG_ENV_SIZE 0x1000 >> +#define CONFIG_ENV_IS_IN_FAT >> +#define CONFIG_FAT_WRITE > > This has been defined in > --->8--- > #if defined(CONFIG_CMD_USB) || defined(CONFIG_CMD_MMC) > #define CONFIG_CMD_FAT > #define CONFIG_FAT_WRITE > ---<8--- Okay, you are right. Will do. Best Regards, Josh Wu > >> +#define FAT_ENV_INTERFACE "mmc" >> +#define FAT_ENV_FILE "uboot.env" >> +#define FAT_ENV_DEVICE_AND_PART "0" >> +#define CONFIG_ENV_SIZE 0x4000 >> #define CONFIG_BOOTCOMMAND "fatload mmc 0:1 0x21000000 >> at91-sama5d3_xplained.dtb; " \ >> "fatload mmc 0:1 0x22000000 zImage; " \ >> "bootz 0x22000000 - 0x21000000" >> -#define CONFIG_SYS_MMC_ENV_DEV 0 >> #else >> #define CONFIG_ENV_IS_NOWHERE >> #endif >> > > Best Regards, > Bo Shen