public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 3/5] common/board_r: manual relocation for cmd table
Date: Tue, 20 Jan 2015 00:41:54 +0100	[thread overview]
Message-ID: <54BD9642.80908@googlemail.com> (raw)
In-Reply-To: <CAPnjgZ23uLh3Ku9hnkBt95dQS1jBZaSGn7xb1YwFqdFHYOfXsg@mail.gmail.com>

Hi Simon,

On 20.01.15 00:34, Simon Glass wrote:
> Hi Andreas,
> 
> On 19 January 2015 at 16:29, Andreas Bie?mann
> <andreas.devel@googlemail.com> wrote:
>> This is required for architectures still need manual relocation like avr32, mk68
>> and others.
>>
>> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>> ---
>>
>>  common/board_r.c |   12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/common/board_r.c b/common/board_r.c
>> index a301cc2..e712902 100644
>> --- a/common/board_r.c
>> +++ b/common/board_r.c
>> @@ -294,6 +294,15 @@ static int initr_announce(void)
>>         return 0;
>>  }
>>
>> +#ifdef CONFIG_NEEDS_MANUAL_RELOC
>> +static int initr_manual_reloc_cmdtable(void)
>> +{
>> +       fixup_cmdtable(ll_entry_start(cmd_tbl_t, cmd),
>> +                      ll_entry_count(cmd_tbl_t, cmd));
>> +       return 0;
>> +}
>> +#endif
>> +
>>  #if !defined(CONFIG_SYS_NO_FLASH)
>>  static int initr_flash(void)
>>  {
>> @@ -718,6 +727,9 @@ init_fnc_t init_sequence_r[] = {
>>         initr_serial,
>>         initr_announce,
>>         INIT_FUNC_WATCHDOG_RESET
>> +#ifdef CONFIG_NEEDS_MANUAL_RELOC
>> +       initr_manual_reloc_cmdtable,
>> +#endif
>>  #ifdef CONFIG_PPC
>>         initr_trap,
>>  #endif
>> --
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Why do you need manual reloc? Is this a toolchain bug?

Just not implemented yet for avr32. It is on my list, but avr32 has not
my highest priority ;)
As long as there are other arches which need this also I think it is
some more time to shift ... the generic board deadline end of 2014 was a
bit stricter, I don't want to kick avr32 out of u-boot now. So let's get
generic board working for avr32 in the next release ;)

Best regards

Andreas Bie?mann

  reply	other threads:[~2015-01-19 23:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 23:29 [U-Boot] [RFC PATCH 0/5] avr32: add generic board Andreas Bießmann
2015-01-19 23:29 ` [U-Boot] [RFC PATCH 1/5] avr32: use dlmalloc for DMA buffers Andreas Bießmann
2015-01-19 23:29 ` [U-Boot] [RFC PATCH 2/5] avr32: rename cpu_init() -> arch_cpu_init() Andreas Bießmann
2015-01-19 23:29 ` [U-Boot] [RFC PATCH 3/5] common/board_r: manual relocation for cmd table Andreas Bießmann
2015-01-19 23:34   ` Simon Glass
2015-01-19 23:41     ` Andreas Bießmann [this message]
2015-01-20  0:13       ` Simon Glass
2015-01-20 12:42     ` Alexey Brodkin
2015-01-27 15:18     ` Michal Simek
2015-01-19 23:29 ` [U-Boot] [RFC PATCH 4/5] avr32: add generic board support Andreas Bießmann
2015-01-19 23:29 ` [U-Boot] [RFC PATCH 5/5] grasshopper: enable generic board Andreas Bießmann
2015-01-20  8:54 ` [U-Boot] [RFC PATCH 0/5] avr32: add " Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BD9642.80908@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox