From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Unreadable UBIFS partition after power cuts
Date: Tue, 20 Jan 2015 08:26:47 +0100 [thread overview]
Message-ID: <54BE0337.4060505@denx.de> (raw)
In-Reply-To: <CANCpNEJs8=PxDU+6p9EB6mWtsYnPRcbHy4Ozhvh9YpW84fP5YQ@mail.gmail.com>
Hello Anton,
Am 19.01.2015 12:29, schrieb Anton Habegger:
> Hello Heiko
>
> I was able to enable the uibfs_replay_journal, and so far this solved my issue.
Great to hear!
> Below the patch. I'm not sure about the U-Boot replacement for
> atomic_long_read? I assume U-Boot has no concurrency, then maybe it is
> safe, just to assign the long direct.
Yes and no ... We have no processes or threads in U-Boot, so we should
have no concurrency here, but you should introduce atomic_long_read()
instead, so we have no difference to linux code. There is already in
U-Boot code atomic.h ... but atomic_long_read() is missing ... so, it
should not so difficult to intriduce this missing function, thanks!
> Is this correct?
> Furthermore I wasn't able to enable the error case,
> ubifs_destroy_journal, because there
> is a dependency to the garbage collector gc.c. So far I didn't found
> time to integrate this stuff.
> What do you think, Is this the right way to fix this issue?
Yes, you are on the right way ... thanks for your work!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2015-01-20 7:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 12:52 [U-Boot] Unreadable UBIFS partition after power cuts Anton Habegger
2015-01-14 14:57 ` Heiko Schocher
2015-01-14 17:12 ` Anton Habegger
2015-01-15 7:28 ` Heiko Schocher
2015-01-16 15:10 ` Anton Habegger
2015-01-16 15:21 ` Anton Habegger
2015-01-16 15:42 ` Bill Pringlemeir
2015-01-16 17:47 ` Anton Habegger
2015-01-17 16:06 ` Anton Habegger
2015-01-18 10:07 ` Heiko Schocher
2015-01-19 11:29 ` Anton Habegger
2015-01-20 7:26 ` Heiko Schocher [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-16 15:38 Anton Habegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BE0337.4060505@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox