From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 20 Jan 2015 08:26:47 +0100 Subject: [U-Boot] Unreadable UBIFS partition after power cuts In-Reply-To: References: <150521CB44B50A4A98049E9C7BAFB0F30D9B823F@DETENEXMB01.delta.corp> <54B683DB.2030108@denx.de> <150521CB44B50A4A98049E9C7BAFB0F30D9B8760@DETENEXMB01.delta.corp> <54B76C26.6010809@denx.de> <150521CB44B50A4A98049E9C7BAFB0F30D9C15C8@DETENEXMB01.delta.corp> <87iog63f6r.fsf@nbsps.com> <54BB85D1.2030209@denx.de> Message-ID: <54BE0337.4060505@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Anton, Am 19.01.2015 12:29, schrieb Anton Habegger: > Hello Heiko > > I was able to enable the uibfs_replay_journal, and so far this solved my issue. Great to hear! > Below the patch. I'm not sure about the U-Boot replacement for > atomic_long_read? I assume U-Boot has no concurrency, then maybe it is > safe, just to assign the long direct. Yes and no ... We have no processes or threads in U-Boot, so we should have no concurrency here, but you should introduce atomic_long_read() instead, so we have no difference to linux code. There is already in U-Boot code atomic.h ... but atomic_long_read() is missing ... so, it should not so difficult to intriduce this missing function, thanks! > Is this correct? > Furthermore I wasn't able to enable the error case, > ubifs_destroy_journal, because there > is a dependency to the garbage collector gc.c. So far I didn't found > time to integrate this stuff. > What do you think, Is this the right way to fix this issue? Yes, you are on the right way ... thanks for your work! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany