public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peng Fan <B51431@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mtd:mxs:nand support oobsize bigger than 512
Date: Tue, 20 Jan 2015 21:12:41 +0800	[thread overview]
Message-ID: <54BE5449.6070609@freescale.com> (raw)
In-Reply-To: <201501201203.49418.marex@denx.de>

Hi, Marek

On 1/20/2015 7:03 PM, Marek Vasut wrote:
> On Friday, December 19, 2014 at 05:39:13 AM, Peng Fan wrote:
>> If ecc chunk data size is 512 and oobsize is bigger than 512, there is
>> a chance that block_mark_bit_offset conflicts with bch ecc area.
>>
>> The following graph is modified from kernel gpmi-nand.c driver with each
>> data block 512 bytes.
>> We can see that Block Mark conflicts with ecc area from bch view.
>> We can enlarge the ecc chunk size to avoid this problem to those oobsize
>> which is larger than 512.
> What exactly is the impact of this patch for current installations of U-Boot?
> Does the NAND need to be rewritten with new content? Is the format introduced
> by this patch compatible with Linux?
The patch does not affect current installations of U-boot.  The NAND 
will not be rewritten with new content for chips whose oobsize is 
smaller than 512. To chips whose oobsize is bigger than 512, new 
format(saying gf_len is 14 and ecc chunk data size is 1024) introduced 
in this patch will be used.

This patch is to support nand chips whose oobsize bigger than 512, since 
the current mxs nand driver only supports oobisze smaller than 512. Data 
maybe corrupted if oobsize is bigger than 512 while ecc chunk data size 
is still 512, this is what this patch is try to fix. Yeah the format is 
compatible with gpmi-nand.c in linux.
> Thanks!
>
> Best regards,
> Marek Vasut
Thanks,
Peng.

  reply	other threads:[~2015-01-20 13:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19  4:39 [U-Boot] [PATCH 1/2] mtd:mxs:nand calculate ecc strength dynamically Peng Fan
2014-12-19  4:39 ` [U-Boot] [PATCH 2/2] mtd:mxs:nand support oobsize bigger than 512 Peng Fan
2015-01-20  6:35   ` Peng Fan
2015-01-20 11:03   ` Marek Vasut
2015-01-20 13:12     ` Peng Fan [this message]
2015-01-22  7:09       ` Marek Vasut
2015-01-20  6:35 ` [U-Boot] [PATCH 1/2] mtd:mxs:nand calculate ecc strength dynamically Peng Fan
2015-01-20 11:04   ` Marek Vasut
2015-01-20 13:18     ` Peng Fan
2015-01-20 11:02 ` Marek Vasut
2015-01-27 23:14 ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BE5449.6070609@freescale.com \
    --to=b51431@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox