From mboxrd@z Thu Jan 1 00:00:00 1970 From: Graeme Russ Date: Thu, 22 Jan 2015 15:24:05 +1100 Subject: [U-Boot] [PATCH 1/5] Add debug output to mx29 SPL source files In-Reply-To: <201501220024.52212.marex@denx.de> References: <1421841318-3014-1-git-send-email-gruss@tss-engineering.com> <1421841318-3014-2-git-send-email-gruss@tss-engineering.com> <201501220024.52212.marex@denx.de> Message-ID: <54C07B65.6060407@tss-engineering.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 22/01/15 10:24, Marek Vasut wrote: > On Wednesday, January 21, 2015 at 12:55:14 PM, Graeme Russ wrote: >> Signed-off-by: Graeme Russ > > Hi! > > - Commit message is missing. > - Some of the debug outputs are missing newline (\n) character > - You can use __func__ and __LINE__ in the debug output to better > specify where the debug spit happened. I saw something earlier on the list about this - I thought the feeling was to use descriptive strings that are easy to grep rather than __func__ and __LINE__, or maybe I misread > > Oh, and the CC list looks pretty random. You can just add "Cc: " tag > into the patches so that git handles it correctly. Cc list was generated by patman (I added Damien as his patch is what mine are based on) Regards, Graeme