From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 22 Jan 2015 10:58:26 +0100 Subject: [U-Boot] [PATCH 07/14] arm: mx6: cm-fx6: display compulab logo In-Reply-To: <1421224974-16631-8-git-send-email-nikita@compulab.co.il> References: <1421224974-16631-1-git-send-email-nikita@compulab.co.il> <1421224974-16631-8-git-send-email-nikita@compulab.co.il> Message-ID: <54C0C9C2.4030502@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Nikita, On 14/01/2015 09:42, Nikita Kiryanov wrote: > Add compulab logo and display it on boot. > > Signed-off-by: Nikita Kiryanov > Cc: Stefano Babic > Cc: Igor Grinberg > --- > include/configs/cm_fx6.h | 3 +++ > tools/logos/compulab.bmp | Bin 0 -> 31810 bytes > 2 files changed, 3 insertions(+) > create mode 100644 tools/logos/compulab.bmp > > diff --git a/include/configs/cm_fx6.h b/include/configs/cm_fx6.h > index a9f33a9..5d0d303 100644 > --- a/include/configs/cm_fx6.h > +++ b/include/configs/cm_fx6.h > @@ -306,4 +306,7 @@ > #define CONFIG_CONSOLE_MUX > #define CONFIG_VIDEO_SW_CURSOR > > +#define CONFIG_VIDEO_LOGO > +#define CONFIG_VIDEO_BMP_LOGO > + This is a general question, not strictly related to the patch. You add with the series a way to get splash screen from multiple sources. I have often (I know we are talking about different things..) used splash screen as a way to add a logo, without the necessity to link the image to the code. I think also that the way with logo does not scale well, and we cannot merge in mainline tons of images - they have nothing to do with u-boot sources. Why is not enough for you to use the splash screen functionality ? IMHO it is much more flexible as using the logo, and there is no need to link it against the code. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================