public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] Using __func__ and __LINE__ in debug outputs
@ 2015-01-23  3:23 Graeme Russ
  0 siblings, 0 replies; only message in thread
From: Graeme Russ @ 2015-01-23  3:23 UTC (permalink / raw)
  To: u-boot

Hi All,

What is the general consensus on using __func__ and __LINE__ in debug 
outputs?

My personal opinion is that distinct statements that can be grep'd are 
better for a couple of reasons:
  - It keeps the debug statements shorter
  - If your running a slightly older version of U-Boot, the line numbers 
(and possibly even the function names) may not match the current version 
of the source code

Regardless of whether we should use __func__ and __LINE__, greping for 
__func__ yields 1,837 hits with inconsistent usage. Should we not simply 
have a #define which tells debug() to output the function and line 
number in a consistent manner?

Regards,


Graeme

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-01-23  3:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-23  3:23 [U-Boot] Using __func__ and __LINE__ in debug outputs Graeme Russ

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox