* [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control
@ 2015-01-14 8:37 Jaehoon Chung
2015-01-23 13:43 ` Jaehoon Chung
2015-02-23 17:36 ` Pantelis Antoniou
0 siblings, 2 replies; 5+ messages in thread
From: Jaehoon Chung @ 2015-01-14 8:37 UTC (permalink / raw)
To: u-boot
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/mmc/dw_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
index b18c75d..76fa0b0 100644
--- a/drivers/mmc/dw_mmc.c
+++ b/drivers/mmc/dw_mmc.c
@@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
if (mmc->ddr_mode)
regs |= DWMCI_DDR_MODE;
else
- regs &= DWMCI_DDR_MODE;
+ regs &= ~DWMCI_DDR_MODE;
dwmci_writel(host, DWMCI_UHS_REG, regs);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control
2015-01-14 8:37 [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control Jaehoon Chung
@ 2015-01-23 13:43 ` Jaehoon Chung
2015-01-23 13:44 ` Pantelis Antoniou
2015-02-23 17:36 ` Pantelis Antoniou
1 sibling, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2015-01-23 13:43 UTC (permalink / raw)
To: u-boot
Hi
Could you check this patch?
Best Regards,
Jaehoon Chung
On 01/14/2015 05:37 PM, Jaehoon Chung wrote:
> If mode is not DDR-mode, then it needs to clear it.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/mmc/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index b18c75d..76fa0b0 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
> if (mmc->ddr_mode)
> regs |= DWMCI_DDR_MODE;
> else
> - regs &= DWMCI_DDR_MODE;
> + regs &= ~DWMCI_DDR_MODE;
>
> dwmci_writel(host, DWMCI_UHS_REG, regs);
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control
2015-01-23 13:43 ` Jaehoon Chung
@ 2015-01-23 13:44 ` Pantelis Antoniou
2015-01-23 13:48 ` Jaehoon Chung
0 siblings, 1 reply; 5+ messages in thread
From: Pantelis Antoniou @ 2015-01-23 13:44 UTC (permalink / raw)
To: u-boot
Hi Jaehoon,
> On Jan 23, 2015, at 15:43 , Jaehoon Chung <jh80.chung@gmail.com> wrote:
>
> Hi
>
> Could you check this patch?
>
Ugh, sorry missed this; did it end up assigned at patchwork to me?
The patch is obviously correct.
> Best Regards,
> Jaehoon Chung
>
Regards
? Pantelis
> On 01/14/2015 05:37 PM, Jaehoon Chung wrote:
>> If mode is not DDR-mode, then it needs to clear it.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> drivers/mmc/dw_mmc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
>> index b18c75d..76fa0b0 100644
>> --- a/drivers/mmc/dw_mmc.c
>> +++ b/drivers/mmc/dw_mmc.c
>> @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
>> if (mmc->ddr_mode)
>> regs |= DWMCI_DDR_MODE;
>> else
>> - regs &= DWMCI_DDR_MODE;
>> + regs &= ~DWMCI_DDR_MODE;
>>
>> dwmci_writel(host, DWMCI_UHS_REG, regs);
>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control
2015-01-23 13:44 ` Pantelis Antoniou
@ 2015-01-23 13:48 ` Jaehoon Chung
0 siblings, 0 replies; 5+ messages in thread
From: Jaehoon Chung @ 2015-01-23 13:48 UTC (permalink / raw)
To: u-boot
Dear Pantelis.
On 01/23/2015 10:44 PM, Pantelis Antoniou wrote:
> Hi Jaehoon,
>
>> On Jan 23, 2015, at 15:43 , Jaehoon Chung <jh80.chung@gmail.com> wrote:
>>
>> Hi
>>
>> Could you check this patch?
>>
>
> Ugh, sorry missed this; did it end up assigned at patchwork to me?
Updated. :)
Best Regards,
Jaehoon Chung
>
> The patch is obviously correct.
>
>> Best Regards,
>> Jaehoon Chung
>>
>
> Regards
>
> ? Pantelis
>
>> On 01/14/2015 05:37 PM, Jaehoon Chung wrote:
>>> If mode is not DDR-mode, then it needs to clear it.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> ---
>>> drivers/mmc/dw_mmc.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
>>> index b18c75d..76fa0b0 100644
>>> --- a/drivers/mmc/dw_mmc.c
>>> +++ b/drivers/mmc/dw_mmc.c
>>> @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
>>> if (mmc->ddr_mode)
>>> regs |= DWMCI_DDR_MODE;
>>> else
>>> - regs &= DWMCI_DDR_MODE;
>>> + regs &= ~DWMCI_DDR_MODE;
>>>
>>> dwmci_writel(host, DWMCI_UHS_REG, regs);
>>>
>>>
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control
2015-01-14 8:37 [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control Jaehoon Chung
2015-01-23 13:43 ` Jaehoon Chung
@ 2015-02-23 17:36 ` Pantelis Antoniou
1 sibling, 0 replies; 5+ messages in thread
From: Pantelis Antoniou @ 2015-02-23 17:36 UTC (permalink / raw)
To: u-boot
Hi Jaehoon,
> On Jan 14, 2015, at 10:37 , Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
> If mode is not DDR-mode, then it needs to clear it.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/mmc/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index b18c75d..76fa0b0 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
> if (mmc->ddr_mode)
> regs |= DWMCI_DDR_MODE;
> else
> - regs &= DWMCI_DDR_MODE;
> + regs &= ~DWMCI_DDR_MODE;
>
> dwmci_writel(host, DWMCI_UHS_REG, regs);
>
> --
> 1.9.1
>
Applied, thanks
? Pantelis
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-23 17:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-14 8:37 [U-Boot] [PATCH] mmc: dw_mmc: fixed the wrong bit control Jaehoon Chung
2015-01-23 13:43 ` Jaehoon Chung
2015-01-23 13:44 ` Pantelis Antoniou
2015-01-23 13:48 ` Jaehoon Chung
2015-02-23 17:36 ` Pantelis Antoniou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox