public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Steve Rae <srae@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/2] fastboot: handle flash write to GPT partitions
Date: Fri, 23 Jan 2015 14:40:02 -0800	[thread overview]
Message-ID: <54C2CDC2.5050606@broadcom.com> (raw)
In-Reply-To: <CAL_JsqJguqX_jJrOZceDM+_5VXFRWwhqCfcR=n5_8_1Qoc3QjA@mail.gmail.com>



On 15-01-23 09:38 AM, Rob Herring wrote:
> On Fri, Dec 12, 2014 at 5:51 PM, Steve Rae <srae@broadcom.com> wrote:
>> Implement a feature to allow fastboot to write the downloaded image
>> to the space reserved for the Protective MBR and the Primary GUID
>> Partition Table.
>> Additionally, prepare and write the Backup GUID Partition Table.
>
> I've been looking at how to do the same thing here. This is an area
> that suffers from each vendor doing whatever they want. Using vendor
> download/flash tools here is painful. They are all different because
> that is where the value add is. ;) What tool do you use on the host
> side to create the image? I have seen some vendor code to do it, or
> you could use parted plus a disk file and extract the partition table
> from it. I find either method a bit fragile and non-standard IMHO.
>
We use an internal tool -- however, I also note that ALL of the source 
code for our tool is "GPL-2.0+" (expect for one file which is Public Domain)
Is U-Boot (Denx) interested in supporting a "host tool"?

> The 2 options I've come up with are 1) enable USB MS and use whatever
> host side tool you like or 2) use the existing "gpt write" command in
> u-boot and tie that into fastboot "oem format" command. The advantage
> and disadvantage of the latter is that it hides the partitioning
> details in u-boot from the user, but requires changing the u-boot env
> to change partition layout. The partitioning requirements are pretty
> SOC specific it seems.
>
We also have code which creates the GPT tables from a "fastboot oem 
format" command, and (if I understand correctly) we have code that 
implements a "gpt" command line, which creates the GPT tables from env 
variables...
If there is interest here, I could investigate further.

> I'm not saying we can't support both, but having some standardization
> here would be good.
>
> Rob
>
I wasn't trying to promote an exclusive solution with this patch (which 
has been accepted - Thanks!). I was just trying to have an incremental 
change to the existing "fastboot flash" command (to handle the GPT Tables).

Thanks, Steve

[... snip ...]

  parent reply	other threads:[~2015-01-23 22:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12 23:51 [U-Boot] [PATCH v4 1/2] disk: part_efi: move code to static functions Steve Rae
2014-12-12 23:51 ` [U-Boot] [PATCH v4 2/2] fastboot: handle flash write to GPT partitions Steve Rae
2014-12-16 14:17   ` Lukasz Majewski
2015-01-23 17:38   ` Rob Herring
2015-01-23 19:57     ` Tom Rini
2015-01-23 22:40     ` Steve Rae [this message]
2015-01-26 14:52       ` Rob Herring
2015-01-26 11:14     ` Lukasz Majewski
2014-12-16 14:16 ` [U-Boot] [PATCH v4 1/2] disk: part_efi: move code to static functions Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C2CDC2.5050606@broadcom.com \
    --to=srae@broadcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox