From: Graeme Russ <gruss@tss-engineering.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v2 PATCH 3/3] arm: mxs: Add 'Wait for JTAG user' if booted in JTAG mode
Date: Sat, 24 Jan 2015 21:32:24 +1100 [thread overview]
Message-ID: <54C374B8.4070008@tss-engineering.com> (raw)
In-Reply-To: <1422070339-14282-4-git-send-email-gruss@tss-engineering.com>
On 24/01/15 14:32, Graeme Russ wrote:
> When booting in JTAG mode, there is no way to use soft break-points, and
> no way of knowing when SPL has finished executing (so the user can issue
> a 'halt' command to load u-boot.bin for example)
>
> Add a debug output and simple loop to stop execution at the completion of
> the SPL initialisation as a pseudo break-point when booting in JTAG mode
>
> Signed-off-by: Graeme Russ <gruss@tss-engineering.com>
> ---
>
> Changes in v2
> - Added and used boot mode #defines
>
> ---
> arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 6 ++++++
> arch/arm/include/asm/arch-mxs/sys_proto.h | 17 +++++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> index 2a5f817..d1457e0 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
> @@ -157,6 +157,12 @@ void mxs_common_spl_init(const uint32_t arg, const uint32_t *resptr,
> data->boot_mode_idx = bootmode;
>
> mxs_power_wait_pswitch();
> +
> +
My bad - I missed this. I'll post a v3
> + if (mxs_boot_modes[data->boot_mode_idx].boot_pads == MXS_BM_JTAG) {
> + debug("SPL: Waiting for JTAG user\n");
> + asm volatile ("x: b x");
> + }
> }
Regards,
Graeme
prev parent reply other threads:[~2015-01-24 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-24 3:32 [U-Boot] [v2 PATCH 0/3] Add support for booting mx28 boards without a battery Graeme Russ
2015-01-24 3:32 ` [U-Boot] [v2 PATCH 1/3] arm: mxs: Add debug outputs and comments to mxs SPL source files Graeme Russ
2015-01-24 3:32 ` [U-Boot] [v2 PATCH 2/3] arm: mxs: Enable booting of mx28 without battery Graeme Russ
2015-01-24 12:20 ` Fabio Estevam
2015-01-24 3:32 ` [U-Boot] [v2 PATCH 3/3] arm: mxs: Add 'Wait for JTAG user' if booted in JTAG mode Graeme Russ
2015-01-24 10:32 ` Graeme Russ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C374B8.4070008@tss-engineering.com \
--to=gruss@tss-engineering.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox