From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 26 Jan 2015 10:35:03 +0100
Subject: [U-Boot] [PATCH 15/19] dm: powerpc: ppc4xx: Move glacier to use
 driver model for serial
In-Reply-To: <54C60795.9030500@denx.de>
References: <1418653194-16873-1-git-send-email-sjg@chromium.org>	<1418653194-16873-16-git-send-email-sjg@chromium.org>
	<54C60795.9030500@denx.de>
Message-ID: <54C60A47.9040501@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 26.01.2015 10:23, Stefan Roese wrote:
>> diff --git a/board/amcc/canyonlands/Kconfig b/board/amcc/canyonlands/Kconfig
>> index 0fc6877..cbc5ff9 100644
>> --- a/board/amcc/canyonlands/Kconfig
>> +++ b/board/amcc/canyonlands/Kconfig
>> @@ -29,4 +29,13 @@ config ARCHES
>>
>>    endchoice
>>
>> +config DM
>> +	default y
>> +
>> +config DM_SERIAL
>> +	default y
>> +
>> +config SYS_MALLOC_F_LEN
>> +	default 0x400
>> +
>
> Hmmm. This does not seem to work. With your patch series applied on
> current top-of-tree I get this error (for glacier_ramboot or
> canyonlands):
>
> $ make -s -j10
> board/amcc/canyonlands/Kconfig:38:warning: config symbol defined without type
> drivers/serial/serial-uclass.c:29:2: error: #error "Serial is required before relocation - define CONFIG_SYS_MALLOC_F_LEN to make this work"
> make[1]: *** [drivers/serial/serial-uclass.o] Error 1
>
> Somehow the CONFIG_SYS_MALLOC_F_LEN define is not available in the
> .config used. Do you have any idea why it might be missing?

Okay. Found it. Its the missing type here. I'll send some follow-up 
patches once I have all tested on canyonlands here.

Thanks,
Stefan