From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 27 Jan 2015 15:38:37 +0100 Subject: [U-Boot] [U-Boot, v2] spl: Change debug to printf for "Unsupported boot-device" In-Reply-To: <20150127142253.GJ10826@bill-the-cat> References: <1415729035-9765-1-git-send-email-sr@denx.de> <20141124221056.GQ21184@bill-the-cat> <20150127142253.GJ10826@bill-the-cat> Message-ID: <54C7A2ED.8090409@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27.01.2015 15:22, Tom Rini wrote: >>>> We had the problem on an AM33xx platform, that SPL detected an >>>> unsupported boot-device. But since this message is a debug message >>>> it took a bit of time to really know, where the hangup in SPL >>>> resulted from. So let's change this debug message to a printf >>>> and also print the detected boot-device that is not supported. >>>> This makes debugging of such cases much easier. >>>> >>>> Signed-off-by: Stefan Roese >>>> Cc: Wolfgang Denk >>>> Cc: Tom Rini >>>> Acked-by: Heiko Schocher >>> >>> Applied to u-boot/master, thanks! >>> >>> >> This patch is causing problem on Microblaze because SPL exceed 4k limit. >> It is only one printf which is called in entire SPL that's why this should >> be solved a little bit differently. > > OK, but for clarity you need and are using both > CONFIG_SPL_SERIAL_SUPPORT and CONFIG_SPL_LIBCOMMON_SUPPORT because > you're using puts but not printf, yes? Right. If this is the case (only puts usage on Microblaze), then its perhaps best that I change this line to puts as well. Okay? Thanks, Stefan