public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] lcd: fix console address is not initialized
Date: Wed, 28 Jan 2015 09:08:03 +0800	[thread overview]
Message-ID: <54C83673.3000209@atmel.com> (raw)
In-Reply-To: <54C7A4A0.8070001@compulab.co.il>

Hi Nikita Kiryanov,

On 01/27/2015 10:45 PM, Nikita Kiryanov wrote:
>> Can we use the following patch to fix this issue?
>> --->8---
>> diff --git a/common/lcd.c b/common/lcd.c
>> index cc34b8a..1195a54 100644
>> --- a/common/lcd.c
>> +++ b/common/lcd.c
>> @@ -268,6 +268,7 @@ void lcd_clear(void)
>>          console_rows = panel_info.vl_row / VIDEO_FONT_HEIGHT;
>>   #endif
>>          console_cols = panel_info.vl_col / VIDEO_FONT_WIDTH;
>> +       lcd_init_console(lcd_base, console_rows, console_cols);
>>          lcd_init_console(lcd_logo(), console_rows, console_cols);
>>          lcd_sync();
>>   }
>> ---8<---
>>
>> It first initializes the lcd console with LCD base, if the splash
>> screen is used, new address is updated.
>
>
> I think this is the best approach. I am very close to posting the next

Thanks for review. I think send this fix patch first, and then you can 
based on this patch for your next step, or else, we can not know how 
long it will break most Atmel SoC related boards on master branch. So, I 
will send this patch and try to get it applied as soon as possible.

Thanks again.

> step in my refactor of lcd.c, and I can
> incorporate it in the series. I will greatly appreciate your help in
> testing this series, since it involves Atmel
> related changes.
>
>>
>> I need this kind of fix to be applied as soon as possible, or else,
>> most Atmel related board are broken on u-boot master branch.
>>
>> Best Regards,
>> Bo Shen
>
> --
> Regards,
> Nikita Kiryanov

Best Regards,
Bo Shen

  reply	other threads:[~2015-01-28  1:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  4:37 [U-Boot] [PATCH] lcd: fix console address is not initialized Bo Shen
2015-01-22 13:10 ` Nikita Kiryanov
2015-01-23  1:20   ` Bo Shen
2015-01-26  5:55     ` Bo Shen
2015-01-27 14:45       ` Nikita Kiryanov
2015-01-28  1:08         ` Bo Shen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-01-28  1:13 Bo Shen
2015-01-29  8:51 ` Anatolij Gustschin
2015-01-29  8:55   ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C83673.3000209@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox