From: Steve Rae <srae@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fastboot: Add USB cable detect check
Date: Thu, 29 Jan 2015 14:49:43 -0800 [thread overview]
Message-ID: <54CAB907.3080809@broadcom.com> (raw)
In-Reply-To: <1422306881-22087-1-git-send-email-robh@kernel.org>
On 15-01-26 01:14 PM, Rob Herring wrote:
> Add a check for USB cable attached and only enter fastboot when a cable
> is attached.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> common/cmd_fastboot.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> index b72f4f3..346ab80 100644
> --- a/common/cmd_fastboot.c
> +++ b/common/cmd_fastboot.c
> @@ -20,6 +20,12 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
> if (ret)
> return ret;
>
> + if (!g_dnl_board_usb_cable_connected()) {
> + puts("\rUSB cable not detected.\n" \
> + "Command exit.\n");
> + return CMD_RET_FAILURE;
> + }
> +
> while (1) {
> if (g_dnl_detach())
> break;
>
(question: the leading "\r" ?!?!)
Reviewed-by: Steve Rae <srae@broadcom.com>
Thanks, Steve
next prev parent reply other threads:[~2015-01-29 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 21:14 [U-Boot] [PATCH] fastboot: Add USB cable detect check Rob Herring
2015-01-29 8:28 ` Lukasz Majewski
2015-01-29 22:49 ` Steve Rae [this message]
2015-01-30 14:00 ` Rob Herring
2015-02-24 10:07 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CAB907.3080809@broadcom.com \
--to=srae@broadcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox