From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Sun, 01 Feb 2015 15:56:52 +0200 Subject: [U-Boot] [PATCH 12/13] lcd: dt: extract simplefb support In-Reply-To: References: <1422530505-19054-1-git-send-email-nikita@compulab.co.il> <1422530505-19054-13-git-send-email-nikita@compulab.co.il> Message-ID: <54CE30A4.4000302@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 01/31/2015 02:25 AM, Simon Glass wrote: > On 29 January 2015 at 04:21, Nikita Kiryanov wrote: >> We now have api functions that can support compiling simplefb code as its own >> module. Since this code is not part of the display functionality, extract it >> to its own file. >> >> Raspberry Pi config file is updated to compile the new file. >> >> Signed-off-by: Nikita Kiryanov >> Cc: Simon Glass >> Cc: Anatolij Gustschin >> Cc: Stephen Warren > > Reviewed-by: Simon Glass > > Could even go in fdtdec.c if you like. Hmm... I'm a little torn, but in the long term I think it's better to keep subsystem-specific fdt code in separate files, because otherwise fdtdec.c will eventually grow to enormous proportions. > >> --- >> board/raspberrypi/rpi/rpi.c | 1 + >> common/Makefile | 1 + >> common/lcd.c | 50 -------------------------------------- >> common/lcd_simplefb.c | 59 +++++++++++++++++++++++++++++++++++++++++++++ >> include/fdt_simplefb.h | 14 +++++++++++ >> include/lcd.h | 3 --- >> 6 files changed, 75 insertions(+), 53 deletions(-) >> create mode 100644 common/lcd_simplefb.c >> create mode 100644 include/fdt_simplefb.h -- Regards, Nikita Kiryanov