[U-Boot] [PATCH 02/21] common/lcd: Add command for setting cursor within lcd-framework

Nikita Kiryanov
2015-02-01T14:48:51Z

Hi Hannes,

On 01/30/2015 03:25 PM, Hannes Petermaier wrote:
> We need this function if we want to make some outputs i.e position the writing
> cursor out of u-boot scripts.

This commit message is inaccurate. Positioning the writing cursor is not in itself output.
Also, what is the use case for such a command?

>
> Signed-off-by: Hannes Petermaier <oe5hpm@oevsv.at>
> ---
> common/lcd.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/common/lcd.c b/common/lcd.c
> index cc34b8a..f418da9 100644
> --- a/common/lcd.c
> +++ b/common/lcd.c
> @@ -279,12 +279,33 @@ static int do_lcd_clear(cmd_tbl_t *cmdtp, int flag, int argc,
> return 0;
> }
>
> +static int do_lcd_setcursor(cmd_tbl_t *cmdtp, int flag, int argc,
> + char *const argv[])
> +{
> + unsigned int col, row;
> +
> + if (argc != 3)
> + return CMD_RET_USAGE;
> +
> + col = simple_strtoul(argv[1], NULL, 10);
> + row = simple_strtoul(argv[2], NULL, 10);
> + lcd_position_cursor(col, row);
> +
> + return 0;
> +}
> +
> U_BOOT_CMD(
> cls, 1, 1, do_lcd_clear,
> "clear screen",
> ""
> );
>
> +U_BOOT_CMD(
> + setcurs, 3, 1, do_lcd_setcursor,
> + "sets cursor for 'puts'",
> + " <row> in character"
> +);
> +

I think it would be better if the U_BOOT_CMD macros were adjacent to the functions they
use. Also, I think this command is better suited for the lcd_console.c file.

> /*----------------------------------------------------------------------*/
>
> static int lcd_init(void *lcdbase)
>

--
Regards,
Nikita Kiryanov