From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Tue, 03 Feb 2015 12:19:28 +0100 Subject: [U-Boot] [PATCH] powerpc, mpc5xx: fix compiler warning In-Reply-To: <20150203195314.4542.AA925319@jp.panasonic.com> References: <1422958219-28178-1-git-send-email-hs@denx.de> <20150203195314.4542.AA925319@jp.panasonic.com> Message-ID: <54D0AEC0.2090903@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Masahiro, Am 03.02.2015 11:53, schrieb Masahiro Yamada: > Hi Heiko, > > > On Tue, 3 Feb 2015 11:10:19 +0100 > Heiko Schocher wrote: > >> executing "tools/buildman/buildman mpc5xx" drops this warning: >> >> common/spl/spl_nor.c: In function 'spl_nor_load_image': >> common/spl/spl_nor.c:26:10: warning: assignment discards 'const' qualifier from pointer target type [enabled by default] >> >> fix this. >> >> Signed-off-by: Heiko Schocher >> --- >> >> common/spl/spl_nor.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/common/spl/spl_nor.c b/common/spl/spl_nor.c >> index 2c0e8e0..dcba2e0 100644 >> --- a/common/spl/spl_nor.c >> +++ b/common/spl/spl_nor.c >> @@ -23,7 +23,7 @@ void spl_nor_load_image(void) >> * Load Linux from its location in NOR flash to its defined >> * location in SDRAM >> */ >> - header = (const struct image_header *)CONFIG_SYS_OS_BASE; >> + header = (struct image_header *)CONFIG_SYS_OS_BASE; >> >> if (image_get_os(header) == IH_OS_LINUX) { >> /* happy - was a Linux */ >> -- >> 2.1.0 > > > > I think you are doing wrong to just suppress the warning. > > > Both image_get_os() and spl_parse_image_header() expect > "const struct image_header *" argument. > > Add "const" to "struct image_header *header;" Yep, fixed, thanks! waiting for more comments before posting v2 bye, Heiko > > > > > Best Regards > Masahiro Yamada > > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany