From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: don't clobber reset cause
Date: Thu, 05 Feb 2015 16:01:57 -0700 [thread overview]
Message-ID: <54D3F665.6050103@boundarydevices.com> (raw)
In-Reply-To: <54D3BB1E.1060409@denx.de>
Hi Stefano,
On 02/05/2015 11:49 AM, Stefano Babic wrote:
> Hi Eric,
>
> On 05/02/2015 19:22, Eric Nelson wrote:
>
>>
>> Certainly, but it seems wrong to make a decision about where and how
>> this might get passed to an O/S in code.
>>
>> If we want to generalize it, I'd be inclined to add commands to
>> query (into a variable) and clear the reset cause.
>>
>> That would still require this patch though.
>
> I do not think there should be a command. The cause must be directly
> associated to the variable, and the reset cause cleared.
>
Okay. Here are two options:
The first one stores the value in 'reset_cause' as a hex
value, and is generally more extensible:
http://patchwork.ozlabs.org/patch/436972/
The second stores it as a human-readable string using
roughly the same names as were previously printed.
I changed the names slightly to avoid embedded whitespace
so the values can be appended to bootargs without escapes:
http://patchwork.ozlabs.org/patch/436974/
I prefer the first, but don't have a strong opinion
one way or the other.
Regards,
Eric
next prev parent reply other threads:[~2015-02-05 23:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 21:51 [U-Boot] [PATCH] imx: don't clobber reset cause Eric Nelson
2015-02-05 16:17 ` Stefano Babic
2015-02-05 16:28 ` Bill Pringlemeir
2015-02-05 17:16 ` Eric Nelson
2015-02-05 17:19 ` Stefano Babic
2015-02-05 17:22 ` Eric Nelson
2015-02-05 17:52 ` Stefano Babic
2015-02-05 18:22 ` Eric Nelson
2015-02-05 18:49 ` Stefano Babic
2015-02-05 22:57 ` [U-Boot] [PATCH] imx: save reset cause in 'reset_cause' environment variable Eric Nelson
2015-02-06 20:36 ` Eric Nelson
2015-02-05 22:58 ` Eric Nelson
2015-02-05 23:06 ` Troy Kisky
2015-02-05 23:14 ` Eric Nelson
2015-02-05 23:17 ` Bill Pringlemeir
2015-02-06 20:40 ` Eric Nelson
2015-02-06 20:56 ` Bill Pringlemeir
2015-02-05 23:01 ` Eric Nelson [this message]
2015-02-05 23:17 ` [U-Boot] [PATCH] imx: don't clobber reset cause Troy Kisky
2015-02-10 17:19 ` Eric Nelson
2015-02-10 18:08 ` Bill Pringlemeir
2015-02-11 9:07 ` Stefano Babic
2015-02-11 14:45 ` Eric Nelson
2015-02-15 21:37 ` [U-Boot] [PATCH 1/2] ARM: i.MX: provide access to reset cause through get_imx_reset_cause() Eric Nelson
2015-02-15 21:37 ` [U-Boot] [PATCH 2/2] nitrogen6x: set environment variable reset_cause Eric Nelson
2015-02-17 9:34 ` Stefano Babic
2015-02-17 9:54 ` Stefano Babic
2015-02-17 9:54 ` [U-Boot] [PATCH 1/2] ARM: i.MX: provide access to reset cause through get_imx_reset_cause() Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D3F665.6050103@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox