From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 10 Feb 2015 06:53:19 +0100 Subject: [U-Boot] [PATCH V2 08/10] arm: socfpga: Add Altera Arria V DK support In-Reply-To: <201502092009.50881.marex@denx.de> References: <1422655730-19410-1-git-send-email-marex@denx.de> <1422655730-19410-8-git-send-email-marex@denx.de> <54CF2BA8.8090902@denx.de> <201502092009.50881.marex@denx.de> Message-ID: <54D99CCF.6050806@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09.02.2015 20:09, Marek Vasut wrote: > On Monday, February 02, 2015 at 08:47:52 AM, Stefan Roese wrote: >> On 30.01.2015 23:08, Marek Vasut wrote: >>> Add support for the Altera Arria V development kit. >>> >>> Signed-off-by: Marek Vasut >>> Cc: Chin Liang See >>> Cc: Dinh Nguyen >>> Cc: Pavel Machek >>> Cc: Stefan Roese >>> Cc: Vince Bridgers >>> --- > > [...] > >>> +/* The rest of the configuration is shared */ >>> +#include >>> + >>> +#endif /* __CONFIG_SOCFPGA_ARRIA5_H__ */ >> >> Without really diff'ing this file with socfpga_cyclone5.h, I'm pretty >> sure that they share many lines. Wouldn't it make sense to move those >> common defines / configs to a common file instead (socfpga_common.h)? > > Hi! > > I agree they share a lot, but I would not recommend moving any of this > into socfpga_common.h . Not all boards which include socfpga_common.h > will want all that's common between socfpga_cyclone5.h and socfpga_arria5.h > as well. > > We need to switch to DM really soon, since without DM, we cannot really > make any "common" configuration. The socfpga_cyclone5.h file in fact > represents a configuration for SoCDK with Cyclone 5, same for Arria 5. > > Unless you have any suggestion, I'd just apply this stuff as is for now > with the note that these config files must be cleaned up once DM is in > place. Or do you have any suggestions please ? No. Please go ahead with this series. We can merge stuff later as well. Once we have better view on how this multi-board support for SoCFPGA will really end up. Thanks, Stefan